-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 David, thanks for your work.
David Hislop wrote: > 1. src/conv/text/TextListenerImpl.h > *28a29 >> #ifndef _MSC_VER > 29a31 >> #endif // _MSC_VER This one I do not really understand :-( > *2. src/conv/*/Makefile.am > *(changes to each of the three files identical to this one for the > wpd2raw file - for some reason MinGW broke with the trailing /, but > Linux didn't mind it not being present, so I removed it) > 9c9 > < AM_CXXFLAGS = $(LIBWPD_CXXFLAGS) $(DEBUG_CXXFLAGS) > -I$(top_srcdir)/src/lib/ > --- >> AM_CXXFLAGS = $(LIBWPD_CXXFLAGS) $(DEBUG_CXXFLAGS) -I$(top_srcdir)/src/lib > 11c11 > < wpd2raw_LDFLAGS = -L../../lib/ > --- >> wpd2raw_LDFLAGS = -L../../lib I committed this one to both fs_experimental and to head. Thanks a lot. > *3. MS VC Project files > *How do you want me to send these to you? Zipped with paths? > One possible drawback: they are for MS Visual Studio 2005, which is what > I've used, so they won't work with VC6 for example. OK, that can a problem. Send me a zipped VS2005 files and I will try to see how I rewrite them manually for VC6. > *Errors and warnings > *Only one lot of warnings in MS VC. In two places in > WPXStreamImplementation.cpp the following code caused the warnings below > due to curpos and streamSize being long and numBytes size_t (and g++ on > Linux and MinGW do not produce the warning): > long curpos = d->buffer.tellg(); > if ( (curpos + numBytes < curpos) /*overflow*/ || > (curpos + numBytes > d->streamSize) ) /*reading more > than available*/ Yeah, the compiler was right, there was actually a signed/unsigned missmatch and it could be potentially dangerous. Thanks for this one too. I committed a fix to the fs_experimental branch > WPXString.cpp > c:\documents and settings\tdh\my documents\visual studio > 2005\projects\libwpd2-fs-exp\src\lib\wpxstring.cpp(153) : warning C4996: > '_vsnprintf' was declared deprecated > c:\program files\microsoft visual studio > 8\vc\include\stdio.h(339) : see declaration of '_vsnprintf' > Message: 'This function or variable may be unsafe. Consider > using _vsnprintf_s instead. To disable deprecation, use > _CRT_SECURE_NO_DEPRECATE. See online help for details.' > Fixed it by defining _CRT_SECURE_NO_DEPRECATE in the project file. Yeah, this is actually a fix that I like, shut the mouth of M$ compiler and leave the code alone :-) > Only one very minor difference in my tests of OLE and non-OLE wpd files > on all three platforms, and it occurred in the output from wpd2raw as > below. One 0.0008 inch difference in the second column width, also > reflected in the overall table width. Is this normal? Or does it > indicate that there might be a problem? > > 51c51 > < openTable(fo:margin-left: 0.0000inch, fo:margin-right: > 0.0000inch, style:width: 6.26*83*inch, table:align: margins, columns: > ((style:column-width: 2.0000inch), (style:column-width: 4.26*83*inch))) > --- >> openTable(fo:margin-left: 0.0000inch, fo:margin-right: > 0.0000inch, style:width: 6.26*75*inch, table:align: margins, columns: > ((style:column-width: 2.0000inch), (style:column-width: 4.26*75*inch))) This looks like an issue in rounding. Would it be possible to have the file? I would like to trace this one at least on my i686 and x86_64 machines to see whether there is a difference. Thanks for your work again Cheers F. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFGMK9Zu9a1imXPdA8RAtvDAJ9vPxGbnn+O2eGXM1k7RVJe4GyN4QCgh3rY 2YvEIo9rMzNO2bUMQILj4IE= =k0ye -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Libwpd-devel mailing list Libwpd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libwpd-devel
