On Sat, 2010-10-23 at 11:45 -0400, William Lachance wrote:
> Hey,
> 
> So after having come back to libwpd after a few years, I realized that
> I made one mistake when designing the external API.
> 
> For various reasons (OOo compatibility, language bindings) we don't
> want to export STL structures (string, map, etc.) in the external API.
> For this reason, I created a class called WPXString to wrap
> std::string. I've since come to realize that this isn't really
> necessary. For libwpd's external API, we can just use const char *,
> which binds quite nicely and has no overhead. For its internal API, we
> can just use std::string straight up.
> 
> Benefits:
> 
> 1. Library becomes easier to understand (no need to look up
> WPXString's various methods), both internally and externally
> 2. Library becomes easier to bind.
> 2. Somewhat reduced overhead.
> 
> Thoughts?

My thoughts would be "Go for it". I always hate custom data structures
anyway.

  Marc


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Libwpd-devel mailing list
Libwpd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libwpd-devel

Reply via email to