Jay Bonci <[EMAIL PROTECTED]> writes:

> Hello everyone. I've taken over maintenance of libwww-perl inside of
> debian (from Michael Dorman).  With the release coming soon, I've
> updated into unstable/ the newest version of libwww-perl from CPAN. It
> is the same as the distribution, with two very small bugfixes, which you
> may wish to roll into the next version:
> 
> I'd attach patches, but these are both one-character fixes
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283916
> 
> Fix: lib/Net/HTTP (line 35):
> my $s = Net::HTTP->new(Host => "www.perl.com") || die $@;
> 
> (Fully quotes www.perl.com in the example)

Applied.

> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=286775
> 
> Fix: lib/Net/HTTP/Methods.pm (line 432):
> $chunk_len =~ s/\;.*//;  # ignore potential chunk parameters
> 
> (Escapes the semi)

This fix is bogus.  The semi does not make any difference, but I've
now applied the following patch that I think avoids the warnings shown
in that bug report.

Regards,
Gisle


Index: lib/Net/HTTP/Methods.pm
===================================================================
RCS file: /cvsroot/libwww-perl/lwp5/lib/Net/HTTP/Methods.pm,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -p -u -r1.17 -r1.18
--- lib/Net/HTTP/Methods.pm     15 Nov 2004 14:16:07 -0000      1.17
+++ lib/Net/HTTP/Methods.pm     30 Dec 2004 12:28:14 -0000      1.18
@@ -426,8 +426,8 @@ sub read_entity_body {
                die "Missing newline after chunk data: '$line'"
                    if !defined($line) || $line ne "";
                $line = my_readline($self);
-               die "EOF when chunk header expected" unless defined($line);
            }
+           die "EOF when chunk header expected" unless defined($line);
            my $chunk_len = $line;
            $chunk_len =~ s/;.*//;  # ignore potential chunk parameters
            unless ($chunk_len =~ /^([\da-fA-F]+)\s*$/) {

Reply via email to