On Sep 6, 2007, at 21:20, TRANS wrote: > On 9/5/07, Dan Janowski <[EMAIL PROTECTED]> wrote: >> libxml at rubyforge (http://rubyforge.org/projects/libxml/) >> >> A new packaged development release from the MEM2 branch (New Memory >> Model) is available: >> >> http://rubyforge.org/frs/?group_id=494&release_id=14239 >> >> Subversion tag available at (use svn checkout): >> >> http://libxml.rubyforge.org/svn/tags/MEM2-0_5_1 >> >> Release notes: >> http://rubyforge.org/frs/shownotes.php?release_id=14239 >> >> Notes: >> Fix child= to do implicit copy when rhs is not a root node. > > I'm a tad hesitant about this change. Probably not at all significant, > but I just wanted to at least note my sense, that maybe it's better > just to raise an error, and force the programmer to be explicit. > It is a good point, one that I considered. But it is not really an error in the large sense. However, it may silently break code (by not raising) which is definitely worse that explicitly breaking it.
Unless there is an opinion to the contrary, I will replace the warning with a raise, but only when using << or child= and not when doing child_add. Dan _______________________________________________ libxml-devel mailing list libxml-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/libxml-devel
