Great work, Dan. After a little work I was seeing this: 227 tests, 1197 assertions, 0 failures, 0 errors
:) Big change from the segfaults we were getting before. A few things I noticed... * as I mentioned before, [] is not implemented for XML::XPath::Object (which is the return value of XML::Document#find and XML::Node#find) * XML::Node#[]=(val) expects val to be a string or nil. before it would accept integers. * no more implicit copies if appending a node from document a into document b. * I actually did get a segfault one time while running a unit test that had a failure, but then I fixed a test and it went away. All in all, great work! We're now using libxml instead of rexml (at least until another segfault rears it's ugly head)! Thanks, -- Christopher P.S. Our test suite runs 3 times faster with libxml vs. rexml. :) On 10/11/07, Dan Janowski <[EMAIL PROTECTED]> wrote: > That is unintentional, it should implement []. > Dan > > On Oct 11, 2007, at 01:45, Christopher J. Bottaro wrote: > > > Hey Dan, > > [] is not implemented for XML::XPath::Object, but it is for > > XML::Node::Set. I made an abstraction layer with pluggable backend > > (libxml, rexml) so it wasn't a big deal for me to implement [] by > > using XML::XPath::Object#collect to convert it to an array, but I just > > thought you'd like to know. > > > > Thanks for the reply. > > -- Christopher > > > > On 10/10/07, Dan Janowski <[EMAIL PROTECTED]> wrote: > >> XML::XPath::Object behaves the same as XML::Node::Set and implements > >> all Set methods. There is a .set receiver on XPath::Object that > >> returns a XML::Node::Set, but it is really a pseudo object as it > >> passes all methods through to Object. > >> > >> There are no updates to the documentation at this time. These changes > >> just occurred. Anyone wishing to do embedded rdoc, please contact me. > >> > >> Dan > >> > >> On Oct 10, 2007, at 19:42, Christopher J. Bottaro wrote: > >> > >>> Did the API change? XML::Document#find used to return > >>> XML::Node::Set > >>> and now it returns XML::XPath::Object. Where can I read about > >>> the API > >>> changes? > >>> > >>> Thanks. > >>> > >>> On 10/10/07, Dan Janowski <[EMAIL PROTECTED]> wrote: > >>>> Release 0.5.2 MEM2 release fixes all known and reported memory > >>>> faults. > >>>> > >>>> project page > >>>> > >>>> http://rubyforge.org/projects/libxml/ > >>>> > >>>> Try it out if you can. > >>>> > >>>> Dan > >>>> _______________________________________________ > >>>> libxml-devel mailing list > >>>> libxml-devel@rubyforge.org > >>>> http://rubyforge.org/mailman/listinfo/libxml-devel > >>>> > >>> _______________________________________________ > >>> libxml-devel mailing list > >>> libxml-devel@rubyforge.org > >>> http://rubyforge.org/mailman/listinfo/libxml-devel > >> > >> _______________________________________________ > >> libxml-devel mailing list > >> libxml-devel@rubyforge.org > >> http://rubyforge.org/mailman/listinfo/libxml-devel > >> > > _______________________________________________ > > libxml-devel mailing list > > libxml-devel@rubyforge.org > > http://rubyforge.org/mailman/listinfo/libxml-devel > > _______________________________________________ > libxml-devel mailing list > libxml-devel@rubyforge.org > http://rubyforge.org/mailman/listinfo/libxml-devel > _______________________________________________ libxml-devel mailing list libxml-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/libxml-devel
