2007/7/1, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
--- branches/qt-gui_qt4/src/widgets/infofield.h (added)
+ InfoField(bool ro = false, QWidget* parent = 0);
I think the first argument should be an enum. So you can write
InfoField(ReadOnly), and not InfoField(true). Or remove the argument
completely use setReadOnly(bool).
+ /**
+ * Old constructor with reversed paremeter order
+ */
+ InfoField(QWidget* parent, bool ro);
This one has to go, its confusing. But maybe that was your plan.
+ using QLineEdit::setText;
Add a comment that this is to get the QString variant.
+ void setData(const char* data)
+ { setText(data); }
I think inline functions should be put after the class declaration,
and not within it. I guess you will remove theses functions later, but
I just wanted to comment on inline in general.
+// Keep old code working until all classes has been updated
+typedef InfoField CInfoField;
sed -i 's/CInfoField/InfoField/g' *
// Erik
--
Erik Johansson
http://ejohansson.se/
