Eugene Paskevich wrote:
On Wed, 11 Jul 2007 18:06:38 +0300, Eugene Paskevich <[EMAIL PROTECTED]> wrote:

Could you please try this patch for qt4 with rewritten small icon to qt4
QSystemTrayIcon?

I did I quick test and it seems to be working but I'm not sure how the tray icon should work so I want input from you guys on this.

In the old (current) code the small icon is added to the system tray for those WMs that support it, otherwise it appears as a floating window just like the default and themed icons. The QSystemTrayIcon will never appears a window so for those WMs (I saw it in WindowMaker and IceWM) there is no status icon at all.

So I see the following options:

1) Use the behavior from Eugene's patch and hope that nobody misses the small status icon on the simpler WMs.

2) Keep the old small icon implementation and add the QSystemTrayIcon as a forth option.

3) Keep the old small icon implementation but only use it if Qt detects a WM that doesn't support the tray icon. This will keep the behavior from the old code but still use the QSystemTrayIcon for those WMs that support it.

4) For option "Small icon" we use the QSystemTrayIcon when possible and revert to Default status icon if the WM doesn't support it. This way we don't need to keep the old Small implementation.

5) Make the QSystemTrayIcon independent of the old status icon implementation allowing the user to have both but also have an option for the status icons to allow the same behavior as #4.


As the current wharf classes do a lot more than is needed by the QSystemTrayIcon I would like to not implement it like them but instead make it a separate class (or perhaps just add it to mainwin if the code is small). My vote is therefor on #5 but it would still be possible to have the behavior of #4 if that is preferred.

Let me know what you think.

And also, thanks Eugene for the patch it saved me some time on figuring out how to use the QSystemTrayIcon =)

/Anders

Reply via email to