Hello,

attached is a patch which makes the LMB behaviour of the KDE tray icon 
consistent with the default behaviour in KDE apps, as implemented in 
kdelibs/kdeui/KSystemTray: (changes marked with (*))

Hidden && Maximized before ==> restore maximized
hidden && minimized|normal before ==> restore normal, raise (*)
Shown  && Minimized ==> show normal|maximized (*)
Shown  && maximized or normal ==> hide

I removed some KDE_VERSION check (it didn't work as expected and is for KDE 
3.2 BETA).

Regards,

Frank

P.S.: Note that I am not subscribed to this list
? kde-trayicon-fix.diff
Index: wharf.cpp
===================================================================
RCS file: /cvsroot/licq/qt-gui/src/wharf.cpp,v
retrieving revision 1.55
diff -u -p -r1.55 wharf.cpp
--- wharf.cpp	18 Nov 2004 13:49:27 -0000	1.55
+++ wharf.cpp	26 Jan 2005 23:33:33 -0000
@@ -708,19 +708,19 @@ void IconManager_KDEStyle::mousePressEve
   switch(e->button())
   {
   case LeftButton:
-    if(mainwin->isVisible())
+    if(mainwin->isVisible() && !mainwin->isMinimized())
       mainwin->hide();
     else
     {
       mainwin->show();
 #ifdef USE_KDE
       KWin::setOnDesktop(mainwin->winId(), KWin::currentDesktop());
-  #if !KDE_IS_VERSION(3,1,94) 
-      mainwin->raise();
-  #endif
-#else
-      mainwin->raise();
 #endif
+      if (mainwin->isMaximized())
+      	mainwin->showMaximized();
+      else
+      	mainwin->showNormal();
+      mainwin->raise();
     }
     break;
    default:

Attachment: pgpD3fiw7zPIQ.pgp
Description: PGP signature

Reply via email to