Hello there,
I've faced a few issues in the search dialog (current CVS):
- no way to type/paste a value in the lineedit when searching by UIN#
- the tab caption is Uin#, then the lineedit label is UIN#. Shouldn't be UIN#
for both since it's an acronym?
The attached patch solves the two issues above (as well as uses a more
appropriate upper bound value for the validator).
- when you search by UIN#, if you get a match (I never got 0 match anyway),
you see the following message in status bar: "65536 more users found. Narrow
search.". This message is obviously wrong.
- the lower bound value (10000) of the QIntValidator used for UIN# seems not
effective. You are able to type values <10000, and that's expected 'cause
the Qt widget+validator allows you type small values (otherwhise you would not
be able to type at all), but maybe the validator's result is simply
ignored/not used because you get no warning when leaving the lineedit and you
are able to go on working with such small value (at least the search is
possible. It might also be the same where QIntValidator's are used for UIN#
as in authuserdlg.cpp, reqauthdlg.cpp, securitudlg.cpp.
Regards,
--
wwp
Index: searchuserdlg.cpp
===================================================================
RCS file: /cvsroot/licq/qt-gui/src/searchuserdlg.cpp,v
retrieving revision 1.46
diff -u -1 -b -p -u -r1.46 searchuserdlg.cpp
--- searchuserdlg.cpp 21 Apr 2005 06:12:48 -0000 1.46
+++ searchuserdlg.cpp 30 Aug 2005 12:52:45 -0000
@@ -235,6 +235,6 @@ SearchUserDlg::SearchUserDlg(CMainWindow
edtUin = new QLineEdit(uin_tab);
- edtUin->setValidator(new QIntValidator(10000,2000000000, this));
+ edtUin->setValidator(new QIntValidator(10000,2147483647, edtUin));
misc_lay->addWidget(edtUin);
- search_tab->addTab(uin_tab, tr("&Uin#"));
+ search_tab->addTab(uin_tab, tr("&UIN#"));
