On Fri, Feb 24, 2006 at 11:33:36AM +0100, Martin Garbe wrote: > Here is the patch for OTR again but now with the corrections which Jon > advised.
Sorry for the delay, have been a bit busy with Life. Anyways, I applied the patch and recompiled all of my plugins and here are my short results. I run 2 licqs with OTRMode = 2 on both. I message a user through the server and my licq crashes. Apparently the patch causes messages from new users to crash Licq. I add the user to my list and then am able to receive the events properly (kinda). I get a message that has "test" and it appends the 0x20 and 0x09 space codes to the end of the message. So I get this on the receiving end: 07:16:21: [OTR] Received message: "test " 07:16:21: [OTR] policyNameToValue: 2 07:16:21: [OTR] inject_message: (recipientname: 249704985, protocol: ICQ) 07:16:21: [SRV] Sending message through server (#30903). 07:16:21: [OTR] Decoded message: test 07:16:21: [SRV] Replace original message with decrypted. Then I get some OTR packets: 07:16:21: [OTR] Received message: "?OTR:AAIKAAAAwLwOm7HOYiundmsTeguS9njBDx1YofMlNiiDv1yLjXdIg2qRZtUmKPIPbC6Pp7Q3tTfiANvC/qk4OL5X+nxiQnfxAfr37cyEKOIUxzcjPAqeJddl5ZXNHv/EcDjikxyQrCINp22cPujoSrYCtOiXqwYuwoo9lr+DdgQ5fSEI7ZiadiiutwxbkJ1CzohjL5c4uPFhW2UVQAFZmIk838T3izhEwj/4RkpbZKMvlx9yzrhCHXlb4VaCpPzJe4/cuEDC9g==." 07:16:21: [OTR] policyNameToValue: 2 07:16:21: [OTR] Create private key for (account:16325723, protocol:ICQ) Good, a private key has been made for myself. Then I reply: 07:17:06: [PKT] Packet (SRVv0, 88 bytes) sent: (192.168.0.100:57857 -> 205.188.1.240:80) 0000: 2A 02 78 BB 00 52 00 04 00 06 00 00 00 00 00 37 *.x».R.........7 0010: 00 00 00 00 00 00 00 00 00 01 09 32 34 39 37 30 ...........24970 0020: 34 39 38 35 00 02 00 30 05 01 00 01 01 01 01 00 4985...0........ 0030: 27 00 00 00 00 6F 6B 21 20 09 20 20 09 09 09 09 '....ok! . .... 0040: 20 09 20 09 20 09 20 20 20 09 20 09 20 20 09 20 . . . . . . 0050: 20 20 09 09 20 20 09 20 .. . This is marked as encrypted when clearly it isn't... I guess I have to wait for the key with the current user to be made? Then I get this 25 seconds later: 07:17:31: [TCP] ProtoOtrDisplaySystemMessage - message: Private key created. username: (null) 07:17:31: [OTR] inject_message: (recipientname: 249704985, protocol: ICQ) 07:17:31: [SRV] Sending message through server (#30908). 07:17:31: [OTR] It's an internal OTR message. Don't show it to user. 07:17:31: [PKT] Packet (SRVv0, 417 bytes) received: (192.168.0.100:57857 <- 205.188.1.240:80) 0000: 2A 02 41 2B 01 9B 00 04 00 07 00 00 86 9C 8A 66 *.A+...........f 0010: 00 00 00 00 00 00 00 00 00 01 09 32 34 39 37 30 ...........24970 0020: 34 39 38 35 00 00 00 04 00 01 00 02 00 50 00 06 4985.........P.. 0030: 00 04 20 00 00 00 00 0F 00 04 00 00 00 EC 00 03 .. ..........ì.. 0040: 00 04 44 10 A8 78 00 02 01 53 05 01 00 01 01 01 ..D.¨x...S...... 0050: 01 01 4A 00 00 00 00 3F 4F 54 52 3A 41 41 49 43 ..J....?OTR:AAIC 0060: 41 41 41 41 78 41 65 39 67 70 45 45 6D 36 4A 61 AAAAxAe9gpEEm6Ja 07:17:31: [OTR] Received message: "?OTR:AAICAAAAxAe9gpEEm6Ja5kALDxZCxI3tfjz/06I/u7Q8xqXGdgwP6wGS3fOevg7dSf80jXT3VnColt+vZaDoW5V3VYXN0LsAYkQUZyo42HWTuA8OSn5g7AySwAFM4cskDs7n8wxIg0KycsygSqZbjozYBt2xt8HfWzMjXsdhMPCkihO2DTA2x+cAgDuYlU3Sn1hFdQrQdSNVj0Gv9EeQk7zPiqq+clgKTDhjOB24055w4jfu6AqNjfrkyzbA/ITBCFvDgkU96r/y1jsAAAAgOO0CSaGgRqIlYwE3TrTvRyxw8VRS18qEeQ+yviUCrdk=." 07:17:31: [OTR] policyNameToValue: 2 07:17:31: [OTR] inject_message: (recipientname: 249704985, protocol: ICQ) 07:17:31: [SRV] Sending message through server (#30909). 07:17:31: [OTR] It's an internal OTR message. Don't show it to user. It sent 2 packets and received one: 07:17:32: [OTR] Received message: "?OTR:AAIRAAAAEI7emoPI3NafF+J9n05BuYIAAAHSpFOLDd66CgQJ8oZDSHp2dspNPSKFKZYqPkfzrUE5F0z0rZfkjzh/L+11QsF+YI8Kkep1OZKaxkbOt9Q3M9E/R6y+GIW0+ewie4cvFze2TqTBCOniY7egzKxOtysaXcxjxAT1QlWYQLo6BuPs56KDWE435IgiOMy9o+q5nqZZFPemQUC7ZkuX/ZfentOQ632CJkPhLDnPJMleNhdJvKBbwWU7rhgfnHvLnl8S32ttQXu80P6skxlQTg6c9oInRebHbDMyVRrhj6iCmL98po0P45cBybNjR+QQjh2YC0neLtRu0zCwZp2hRZ51xEDj89xq/W3gkZoAderiu7ep30pnJsEJpSQVQwJdxbYhxQ30yVUd4fvYZWzbFv97MLHcJLs47IzB+8qqfrfsbjPavkN0sVcAhtpNNS6igB0lAwY68Sc4UZDBpcfqbuykxWtra2LFwKxVJQi83crNBbxnYO67rwkF2uJ2ZprvlAtPSuDcBCuhFnWPJ57iDRYyO01G/Qm/BitZECFEZJdNasr9RBBI342MEbwQil3yLu7TClH9BpF9GI67UE62ZcVzYD42MwbeZ3GRnrBs/08T66kENrHC6gt6QEzHMKgTu5XarQWeUCJ0w/EuaAxXU8DpeUxOV1B6TNI2ww8j." 07:17:32: [OTR] policyNameToValue: 2 07:17:32: [OTR] It's an internal OTR message. Don't show it to user. I just tried to send a message and it is marked as encrypted, but clearly not... but this time I get 2 unknown events: (Unknown Event 07:24:30) [----] 249704985: OTR System Message: New fingerprint received: 21048572 B7C84A62 CCD44916 9EBFEC5D A065736A (Unknown Event 07:24:30) [----] 249704985: OTR System Message: Connection entered secure state. Hmm.. entered secure state finally.. let's see if it is! Ahh.. finally my messages are being sent and received in a secure fashion. My impression is that it takes some time to create an OTR tunnel. Is there anyway that this can be made to go faster and smoother (ie not saying we are encrypted when we arent). I haven't tried any other modes yet because of time.. have to get ready for work. Anyways, I think OTR would be a nice addition to Licq, but first we need to work out the bugs :) Jon -- ________________________________________________________ Jon Keating ICQ: 16325723 [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] http://www.licq.org GPG: 2290A71F http://www.thejon.org HOME: Minamiashigara, Japan
pgpiHXdYxJaMs.pgp
Description: PGP signature