On Fri, Apr 21, 2006 at 10:10:14PM +0200, Martin Garbe wrote: > At the moment there are some problems with the smily system.
Yes.. quite a few small annoying things. BTW s/smily/smiley :) > To solve these problems I wrote this patch. It arranges the smilies > internally in a tree. Urls are handled as protected content where no > replacement of smily should be done. > For example if there are the smilies :) and :-) the tree would look like > : > / \ > ) - > | > ) > So I search in the message only the ':' symbol and look whether is is > part of the smily. If it is a smily and not part of an url it is > replaces by an image. > Additionally the bug mentioned above is fixed here. Ahh, yes this is much better and should work greatly over the regexp we had before. I'm going to be going to a friend's wedding party today, so I don't have time to review it.. but look forward to taking a look at it soon. Jon -- ________________________________________________________ Jon Keating ICQ: 16325723 [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] http://www.licq.org GPG: 2290A71F http://www.thejon.org HOME: Minamiashigara, Japan
pgpux4afGe66F.pgp
Description: PGP signature