On Tue, May 16, 2006 at 11:01:48PM +0200, Erik Johansson wrote: > Attaching the first draft of CBuffer for licq-newapi. Please tell me what you > think, if you love it, hate it, I've missed or failed to understand something > etc. Don't hold back, I can (hopefully) take it :)
Overall it looks good, I just took a quick look at it though.. but did notice a few things. Having only operator+= might be sufficient, but I think we should also have an operator+ that is implemented in terms of operator+=. It would make more sense to have it, if we have operator+=. There is no CBuffer::print() like in the current code. It would be nice to have a print function or 2. One could be used by the operator<<(stream, CBuffer), and then one can be used for packet dumps. Or if we only have one print(), the packet dump function could just make the output of print() prettier. I will take a more detailed look at the code tonight and see if I find anything else. Jon -- ________________________________________________________ Jon Keating ICQ: 16325723 [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] http://www.licq.org GPG: 2290A71F http://www.thejon.org HOME: Minamiashigara, Japan
pgpiE11kPBLgx.pgp
Description: PGP signature
