Smart solution :) Viktor, Rogue Software Architect
20 feb 2009 kl. 19.43 "marius d." <[email protected]> skrev: > > > > On Feb 20, 5:30 pm, Viktor Klang <[email protected]> wrote: >> I unfortunately have been working alot lately and havent had a >> chance to >> check the new GC code out. >> >> Some kind soul who can explain the new solution? > > Well instead of using lift:gc all around the gc polling send up only > the page ID. Functions on the session are no updating with the right > owner in the rendering pipelline. Hence for a GC request we are > updating the last-seen timestamp only for the functions pertaining to > that specific page. > > Of course now if youare removing DOM nodes (or use SHtml) we don't > really know what functions were tight to that node so those will still > be kept around. I really don't think this is a biggie though. Even > with old lift:gc approach there were some corner cases like one can > clone a node, remove it, and later on add it back ... but in the mean > time the function may have been gc-ed (could have happened extremely > rare but it was still there). > > Another benefit now is that gc requests are more lightweight. > > ... and all thanks to Dave's nifty idea ! > >> >> On Fri, Feb 20, 2009 at 4:18 PM, Derek Chen-Becker >> <[email protected]>wrote: >> >> >> >>> Great work! I ran into the issue yesterday and today with an >>> update it >>> seems to be working fine. >> >>> Derek >> >>> On Thu, Feb 19, 2009 at 7:29 PM, David Pollak < >>> [email protected]> wrote: >> >>>> Folks, >>>> Marius made some patches to Lift's GC support today. He removed >>>> the >>>> lift:gc tag so we don't trip over the Firefox namespace issue. >> >>>> I've done some initial testing (and made a few minor updates). >> >>>> Please do a mvn -U clean install and let us know how well the new >>>> code >>>> works. >> >>>> Please also do tests like navigating to a page with form elements >>>> on it, >>>> waiting 45 minutes and then making sure the form can be submitted. >> >>>> Thanks, >> >>>> David >> >>>> -- >>>> Lift, the simply functional web frameworkhttp://liftweb.net >>>> Beginning Scalahttp://www.apress.com/book/view/1430219890 >>>> Follow me:http://twitter.com/dpp >>>> Git some:http://github.com/dpp >> >> -- >> Viktor Klang >> Senior Systems Analyst > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~----------~----~----~----~------~----~------~--~---
