Committed. Let me know if that works for you.
On Jun 5, 6:31 pm, "marius d." <marius.dan...@gmail.com> wrote:
> Oh right ..that makes sense. Thanks Derek !
>
> On Jun 5, 6:28 pm, Derek Chen-Becker <dchenbec...@gmail.com> wrote:
>
> > Well, I meant for a period of time, since we're changing default behavior.
> > If someone expects an empty node to render default messages and then
> > upgrades to 1.1 and it stops spitting it out, that would be confusing. Kind
> > of a deprecation warning, so to speak.
>
> > Derek
>
> > On Fri, Jun 5, 2009 at 8:25 AM, marius d. <marius.dan...@gmail.com> wrote:
>
> > > Personally I don't think that a debug warning is necessary ... since
> > > if the node is empty it is very intuitive for the user that nothing
> > > will be rendered there which leads to an intended behavior.
>
> > > Br's,
> > > Marius
>
> > > On Jun 5, 5:06 pm, Derek Chen-Becker <dchenbec...@gmail.com> wrote:
> > > > +1. If someone explicitly sets it to empty then we should honor that,
> > > > although I wonder if we should emit a debug-level warning.
>
> > > > Derek
>
> > > > On Fri, Jun 5, 2009 at 7:26 AM, Bryan. <germ...@gmail.com> wrote:
>
> > > > > +1 on removing the default text.
>
> > > > > --Bryan
>
> > > > > On Jun 5, 6:46 am, "marius d." <marius.dan...@gmail.com> wrote:
> > > > > > The reason for that is that if the node text is empty (and yes we
> > > > > > explicitly trim it) we render the default text. To be honest I'm not
> > > a
> > > > > > fan of this approach either. I think it should be ok to just not
> > > > > > render a default text. Does anyone have any objections? If not I
> > > could
> > > > > > change this real quick, if yes let's talk about it.
>
> > > > > > Br's,
> > > > > > Marius
>
> > > > > > On Jun 5, 12:48 pm, Jeppe Nejsum Madsen <je...@ingolfs.dk> wrote:
>
> > > > > > > Hi,
>
> > > > > > > I'm trying to remove the "Notice", "Error" lead in text that is
> > > > > > > displayed when using the Msgs snippet, like this:
>
> > > > > > > <lift:snippet type="msgs">
> > > > > > > <lift:notice_msg class="success"></lift:notice_msg>
> > > > > > > <lift:error_msg class="error"></lift:error_msg>
> > > > > > > <lift:warning_msg class="notice"></lift:warning_msg>
> > > > > > > </lift:snippet>
>
> > > > > > > Looking at the code, it seems the default text is used if the
> > > specified
> > > > > > > text is empty, so I tried putting a in there but this also
> > > seems
> > > > > > > to be swallowed.
>
> > > > > > > Is there anyway to do this (besides changing the default property
> > > > > > > values)??
>
> > > > > > > /Jeppe
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en
-~----------~----~----~----~------~----~------~--~---
