Neat, I like your change better, as it's more general. Thanks! As a matter of code review though, the new ControlHelpers function doc comment refers to "ignore" as a list, when it's now a PF.
-Ross On Aug 25, 2009, at 3:46 PM, David Pollak wrote: > I've just pushed a change that should satisfy your requirements. > > On Tue, Aug 25, 2009 at 11:59 AM, Ross Mellgren <[email protected]> > wrote: > > Two weeks ago I posted asking about redirection during snippet > instantiation: in the current version of 1.1, if you try S.redirectTo > (or StatefulSnippet.redirect) while constructing a snippet, it causes > a SnippetFailure.InstantiationException rather than redirecting. > Originally I thought it was more complicated to make this work, but I > looked at it again because the work around I put in place bugged me, > and it turns out it's a pretty small change. > > http://github.com/Dridus/liftweb/commit/3cb2596f502db37a5242eed9ff4127a08953d799 > > I've made the change in a fork, and I was hoping that if it wasn't > thought to be a bad change that it could be pulled into 1.1? > > The original conversation which was essentially between myself and > Naftoli is here: > > http://groups.google.com/group/liftweb/browse_thread/thread/1214840c7196f778/fe80f5a54423eafd > > -Ross > > > > > > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Git some: http://github.com/dpp > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~----------~----~----~----~------~----~------~--~---
