On Tue, Nov 17, 2009 at 7:37 AM, Jeppe Nejsum Madsen <[email protected]> wrote: > On Nov 17, 12:11 am, David Pollak <[email protected]> > wrote: >> On Mon, Nov 16, 2009 at 3:10 PM, Kris Nuttycombe >> <[email protected]>wrote: >> >> >> >> >> >> > On Mon, Nov 16, 2009 at 4:02 PM, David Pollak >> > <[email protected]> wrote: >> >> > > On Mon, Nov 16, 2009 at 2:20 PM, Kris Nuttycombe < >> > [email protected]> >> > > wrote: >> >> > >> On Mon, Nov 16, 2009 at 3:13 PM, David Pollak >> > >> <[email protected]> wrote: >> >> > >> > On Mon, Nov 16, 2009 at 2:12 PM, Kris Nuttycombe >> > >> > <[email protected]> >> > >> > wrote: >> >> > >> >> Hi, all, >> >> > >> >> I was just informed that my changes broke MetaMegaProtoUser >> > >> >> interaction. I've reverted the commit until I can get that sorted >> > out. >> >> > >> > How was it broken? >> >> > >> It's something to do with how the login form is processed - at the >> > >> moment I haven't figured out anything more with that. Essentially, the >> > >> login fails silently and returns the user to the login form upon >> > >> submission. >> >> > > That sounds like a deeper issue with MetaProtoUser. I'd keep your >> > changes >> > > and see why MegaProtoUser is failing. >> >> > Absolutely; I just figured I didn't want to leave people with broken >> > code while I figure it out since I'm not that familiar with >> > MegaProtoUser and am not sure how long that will take. >> >> Please check the code back in and get me a test case and I'll debug it. >> >> I've got about 20 tickets I'm working on right now... one more ain't gonna >> kill me. ;-) > > Did this ever get resolved? I'm still seeing this after an update to > latest. This is pretty major, so I looked into it and found this: > > 1) The Template LocParam defined on loginMenuLoc is never called on > form post, so the login method is never called during post. I assume > this worked before? > 2) If I change the bind for login to include a function that calls > login on submit, the login process works > > Not sure what the correct semantics are wrt 1) above....but something > definately seem to have changed... > > /Jeppe
I just noticed that David committed a fix. Thanks, David! Kris -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=.
