On Tue, Nov 24, 2009 at 1:03 AM, tommycli <[email protected]> wrote: > Amazing - great. For future reference - what's the preferred method > for asking for code/feature to be integrated? >
Discuss on this list, once everyone is happy, open a ticket at GitHub. > > On Nov 23, 9:46 pm, Ross Mellgren <[email protected]> wrote: > > Added an issue for you:http://github.com/dpp/liftweb/issues#issue/205 > > and it's on review board:http://reviewboard.liftweb.net/r/121/ > > > > So it will (probably) be in 1.1-SNAPSHOT in a day or two, assuming the > change isn't unacceptable for whatever reason. > > > > -Ross > > > > On Nov 23, 2009, at 11:50 PM, tommycli wrote: > > > > > Add deleteMenuLocParams to CRUDify. > > > > > Patch below. (I tried github, but you guys don't pull apparently). > > > > > <pre> > > > diff --git a/lift-persistence/lift-mapper/src/main/scala/net/liftweb/ > > > mapper/CRUDify.scala b/lift-persistence/lift-mapper/src/main/scala/net/ > > > liftweb/mapper/CR > > > index 21e5a3b..5aae123 100644 > > > --- a/lift-persistence/lift-mapper/src/main/scala/net/liftweb/mapper/ > > > CRUDify.scala > > > +++ b/lift-persistence/lift-mapper/src/main/scala/net/liftweb/mapper/ > > > CRUDify.scala > > > @@ -265,7 +265,7 @@ trait CRUDify[KeyType, CrudType <: KeyedMapper > > > [KeyType, CrudType]] { > > > > > def defaultValue = Empty > > > > > - def params = Nil > > > + def params = deleteMenuLocParams > > > > > /** > > > * What's the text of the link? > > > @@ -297,6 +297,11 @@ trait CRUDify[KeyType, CrudType <: KeyedMapper > > > [KeyType, CrudType]] { > > > })) > > > } > > > > > + /** > > > + * Override to include new Params for the show all menu > > > + */ > > > + def deleteMenuLocParams: List[Loc.AnyLocParam] = Nil > > > + > > > def deleteMenuName = S.??("Delete")+" "+displayName > > > > > def deleteTemplate(): NodeSeq = pageWrapper(_deleteTemplate) > > > </pre> > > > > > -- > > > > > You received this message because you are subscribed to the Google > Groups "Lift" group. > > > To post to this group, send email to [email protected]. > > > To unsubscribe from this group, send email to > [email protected]<liftweb%[email protected]> > . > > > For more options, visit this group athttp:// > groups.google.com/group/liftweb?hl=en. > > -- > > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<liftweb%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Surf the harmonics -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
