On 05/02/10 5:28 PM, Jeppe Nejsum Madsen wrote:
Naftoli Gugenheim<[email protected]> writes:
David and all,
QUESTION 1
I'm working on issue #258. Here are two options for an overridable parser
(applies to formatting too):
1. def parse(s: String): Box[Date] = ConversionRules.parseDate()(s)
2. def parse: String=>Box[Date] = ConversionRules.parseDate()
What are the pros and cons, and which should I use?
I prefer 1) I see no reason for parse to be a function....
+1
QUESTION 2
MappedDate and MappedDateTime apparently were parsing via LiftRules in
setFromAny, while buildSetStringValue etc. were using (Time)Helpers.toDate. Is
there a reason not to change it? Or, should toDate use ConversionRules?
I think it would be natural for toDate to use ConversionRules....then
ConversionRules becomes the only place where date formatting is handled.
/Jeppe
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
