Thanks!
I'm now trying to customize the attribute-exchange and noticed that it
is embedded in a longish method. I think it would be good if this was
extracted to a method (maybe: def reqAttributeExchange:
Option[FetchRequest] ?) so that ax info could be modified without
digging into the rest of the logic or copy'n'pasting. Specifically, I
think these lines could be extracted:
// Attribute Exchange example: fetching the 'email' attribute
val fetch = FetchRequest.createFetchRequest()
fetch.addAttribute("email",
// attribute alias
"http://schema.openid.net/contact/email";, //
type URI
true); //
required
Erkki L
On Feb 2, 1:33 am, David Pollak <[email protected]> wrote:
> I've changed the code from a val to a def and changed the default value to
> openid_identifier. If this causes code breakage, folks can change it back
> to the old value.
>
> Thanks for the suggestion.
>
>
>
> On Sat, Jan 30, 2010 at 7:58 AM, Erkki Lindpere <[email protected]> wrote:
> > Hi,
>
> > I suggest that Lift-OpenID should have "openid_identifier" as the
> > default post param name instead of "openIdUrl". "openid_identifier" is
> > the one recommended in the OpenID spec. with the idea that user agents
> > may someday special support for that. I think this change would be
> > justified considering Lift's philosophy of providing sensible
> > defaults?
>
> > (not that it's hard to change, but it took me a while to figure out
> > why /openid/login resulted in "not found" -- I used a custom form with
> > the standard field names not the one generated by Lift)
>
> > Erkki
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Lift" group.
> > To post to this group, send email to [email protected].
> > To unsubscribe from this group, send email to
> > [email protected]<liftweb%[email protected]>
> > .
> > For more options, visit this group at
> >http://groups.google.com/group/liftweb?hl=en.
>
> --
> Lift, the simply functional web frameworkhttp://liftweb.net
> Beginning Scalahttp://www.apress.com/book/view/1430219890
> Follow me:http://twitter.com/dpp
> Surf the harmonics
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
