Thanks ------------------------------------- David Pollak<[email protected]> wrote:
On Tue, Feb 9, 2010 at 2:49 PM, Naftoli Gugenheim <[email protected]>wrote: > Sorry - what's the Windows (eclipse) equivalent--i.e., what does that line > do? > Find all the files that contain "FIXME: 280" in the mapper package. > Also I wasn't sure what you meant by 'comments around my code.' > It will become very obvious when you open the files. The entire contents of: ./src/test/scala/net/liftweb/mapper/ManyToManySpecs.scala ./src/main/scala/net/liftweb/mapper/ManyToMany.scala ./src/main/scala/net/liftweb/mapper/OneToMany.scala Are commented out. > Thanks! > > ------------------------------------- > David Pollak<[email protected]> wrote: > > On Tue, Feb 9, 2010 at 2:28 PM, Naftoli Gugenheim <[email protected] > >wrote: > > > Could you give me exact instructions what to do to test my code on 2.8? > > > git checkout -b 280_port_refresh origin/280_port_refresh > cd framework/lift-persistence/lift-mapper > emacs $(grep -l "FIXME: 280" $(find . -name *.scala)) > > remove the comments around your code. Make it compile and pass the > existing > tests. > > > > Thanks. > > > > 2010/2/7 David Pollak <[email protected]> > > > >> > >> > >> On Sun, Feb 7, 2010 at 1:01 PM, Naftoli Gugenheim <[email protected] > >wrote: > >> > >>> So if I get around to it would it indeed be preferable to point it to > >>> SHtml? > >>> > >> > >> Changing the code is one of the lowest priorities I could imagine. I > >> would say that closing the stuff you've had on review board for > 1 > months > >> would be much higher priority. Adding copyright notices and other > headers > >> to the code you've written in Lift is a higher priority. Helping to > port > >> your code to 2.8 would be a higher priority. > >> > >> > >>> > >>> ------------------------------------- > >>> David Pollak<[email protected]> wrote: > >>> > >>> On Sun, Feb 7, 2010 at 12:47 PM, Naftoli Gugenheim < > [email protected] > >>> >wrote: > >>> > >>> > Hello. Why do Mapper's toForm implementations use S.fmapFunc directly > >>> > rather than using SHtml? Is it not duplicate code? > >>> > > >>> > >>> Because the Mapper code was the earliest Lift code... written long > before > >>> SHtml. > >>> > >>> > >>> > Thanks. > >>> > > >>> > -- > >>> > You received this message because you are subscribed to the Google > >>> Groups > >>> > "Lift" group. > >>> > To post to this group, send email to [email protected]. > >>> > To unsubscribe from this group, send email to > >>> > [email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > >>> <liftweb%[email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > >>> > > >>> > . > >>> > For more options, visit this group at > >>> > http://groups.google.com/group/liftweb?hl=en. > >>> > > >>> > > >>> > >>> > >>> -- > >>> Lift, the simply functional web framework http://liftweb.net > >>> Beginning Scala http://www.apress.com/book/view/1430219890 > >>> Follow me: http://twitter.com/dpp > >>> Surf the harmonics > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > Groups > >>> "Lift" group. > >>> To post to this group, send email to [email protected]. > >>> To unsubscribe from this group, send email to > >>> [email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > >>> . > >>> For more options, visit this group at > >>> http://groups.google.com/group/liftweb?hl=en. > >>> > >>> -- > >>> > >>> You received this message because you are subscribed to the Google > Groups > >>> "Lift" group. > >>> To post to this group, send email to [email protected]. > >>> To unsubscribe from this group, send email to > >>> [email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > >>> . > >>> For more options, visit this group at > >>> http://groups.google.com/group/liftweb?hl=en. > >>> > >>> > >> > >> > >> -- > >> Lift, the simply functional web framework http://liftweb.net > >> Beginning Scala http://www.apress.com/book/view/1430219890 > >> Follow me: http://twitter.com/dpp > >> Surf the harmonics > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "Lift" group. > >> To post to this group, send email to [email protected]. > >> To unsubscribe from this group, send email to > >> [email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > >> . > >> For more options, visit this group at > >> http://groups.google.com/group/liftweb?hl=en. > >> > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Lift" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]<liftweb%[email protected]> > <liftweb%[email protected]<liftweb%[email protected]> > > > > . > > For more options, visit this group at > > http://groups.google.com/group/liftweb?hl=en. > > > > > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Surf the harmonics > > -- > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<liftweb%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<liftweb%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Surf the harmonics -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en. -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
