Thanks for the fixes Ross! This library is a really great piece of work. On 2010-02-20, at 12:53 , Ross Mellgren wrote:
> Pushed to master > http://github.com/dpp/liftweb/commit/39c475b373d925133b55437aa578cfc18b6a4442 > > -Ross > > On Feb 18, 2010, at 4:07 PM, Justin Reardon wrote: > >> From the review board diff it looks like you forgot to actually remove the >> call to dontReduce (line 221). Perhaps a test case that will actually fail >> if queryViewDocs were to include the dontReduce call would be good? For >> example querying on view "people_by_age" using queryViewDocs would fail >> presently if run against CouchDB 0.10. >> >> Thanks, >> Justin Reardon >> >> On 2010-02-18, at 15:45 , Ross Mellgren wrote: >> >>> Updated the patch up on review board, so if you think the new patch will >>> work for you, I'll push it once it's reviewed. >>> >>> -Ross >>> >>> On Feb 18, 2010, at 12:28 AM, Justin Reardon wrote: >>> >>>> Wow you're fast. >>>> >>>> You probably shouldn't call dontReduce in queryViewDocsFrom, as recent >>>> versions of couchdb will return an error if this parameter is applied to a >>>> view without a reduce function. This could easily happen in the case of >>>> the linked documents feature I mentioned, or in the case of avoiding large >>>> objects in an index. Also, include_docs=true will cause an error if >>>> reduce=false isn't present when a view does have a reduce function, but at >>>> least it's easier to add the dontReduce than to remove it. >>>> >>>> Thanks, >>>> Justin Reardon >>>> >>>> On 2010-02-17, at 23:46 , Ross Mellgren wrote: >>>> >>>>> Thanks for the suggestion. >>>>> >>>>> I created a ticket: >>>>> http://www.assembla.com/spaces/liftweb/tickets/356-add-ability-to-use-doc-result-of-query--not-just-value >>>>> And the change is on review board: http://reviewboard.liftweb.net/r/216/ >>>>> >>>>> Once that's reviewed and pushed to master you'll be able to query those >>>>> views with the new queryViewDocs function. >>>>> >>>>> Let me know if you run over any more missing features that should be >>>>> added to the integration; I'll try to get them in. >>>>> >>>>> -Ross >>>>> >>>>> On Feb 17, 2010, at 8:52 PM, Justin Reardon wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I've started working with the CouchRecord support and I've run into a >>>>>> bit of a problem with the queryView function. I've been writing views >>>>>> involving both map and reduce so I could generate statistics on some >>>>>> hierarchical data, and access leaves in one view, by using include_docs. >>>>>> As I discovered when my views returned no results in CouchRecord, its >>>>>> implementation is always using the "value" key in the returned row, >>>>>> whereas my views pulled the document in using the "doc" key. >>>>>> >>>>>> For the present its fairly trivial for me to either split the view into >>>>>> two separate ones or perform a slightly cleverer reduce (I've only been >>>>>> counting totals so far), but it would be more convenient if it were >>>>>> possible to do everything in one view. Also, in CouchDB 0.11 they're >>>>>> adding support for linked documents in views, which will place the >>>>>> resulting documents in the "doc" key. The current implementation makes >>>>>> it impossible to use a linked document view to query. >>>>>> >>>>>> Perhaps there could be a version of queryView that uses the "doc" key to >>>>>> generate the actual record, and provide it and the "value" key as a >>>>>> JValue in a tuple, as that value may be occasionally useful too? >>>>>> >>>>>> Thanks, >>>>>> Justin Reardon >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Lift" group. >>>>>> To post to this group, send email to [email protected]. >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]. >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/liftweb?hl=en. >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google Groups >>>>> "Lift" group. >>>>> To post to this group, send email to [email protected]. >>>>> To unsubscribe from this group, send email to >>>>> [email protected]. >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/liftweb?hl=en. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Lift" group. >>>> To post to this group, send email to [email protected]. >>>> To unsubscribe from this group, send email to >>>> [email protected]. >>>> For more options, visit this group at >>>> http://groups.google.com/group/liftweb?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Lift" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/liftweb?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Lift" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/liftweb?hl=en. >> > > > -- > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
