- **Patch**: new --> review
- **Comment**:

passes make, make check and a full make doc



---

** [issues:#4730] Patch: Do not output CC#7 events in MIDI on dynamic changes**

**Status:** Started
**Created:** Fri Jan 08, 2016 03:54 PM UTC by H T LilyPond
**Last Updated:** Fri Jan 08, 2016 04:37 PM UTC
**Owner:** H T LilyPond


Following up on my own comment in 
<https://lists.gnu.org/archive/html/lilypond-user/2015-10/msg00098.html>,

> I've observed that LilyPond actually emits CC#7 events to a generated
> MIDI file on dynamic (MIDI velocity) changes created by the
> Dynamic_performer, but these CC#7 changes seem to always just set the
> MIDI volume to 100 (in the range from 0 to 127).  To me this looks like
> a possible bug (and could be just a remnant of the implementation prior
> to 2.14), but this is only my personal opinion...

I've tried to fix this defect to make the handling of MIDI CC#7 more consistent 
with how the other MIDI channel controls are handled (that is, avoid enforcing 
any "default" values on any controls).  

(This is in preparation for a larger patch to follow for making all MIDI 
controls adjustable from within LilyPond code using context properties; for 
that change, it's best to first reduce any unnecessary automatic adjustment of 
the MIDI channel controls.)

The patch is available for review (with further technical information) at
<https://codereview.appspot.com/277700043/>.



---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

Reply via email to