I tried testing again, once with `configure --disable-optimising` and once with
`configure --enable-checking`. Both times the builds were successful and the
resulting binary worked without errors. I am using LilyDev with gcc version
4.9.2 (and g++ version 4.9.2).
Looking at the code I don't see anything wrong, but I may be missing something
(as a C++ novice).
On the dev list James posted part of the log[1] from when he ran make on
staging, with warnings about type conversions. But David Kastrup noted:
> However, those warnings are produced _after_ (one run of) GCC has
> already aborted (on lily/page-breaking-scheme.cc rather than
> lily/page-breaking.cc), when the remaining jobs are finishing. The
> error messages triggering _that_ should occur before that.
So unless there's a way to get or reproduce those error messages I'm not sure
how to proceed. Two ideas:
1. Setting the page-height to such a large value (in `one-page-breaking.cc`)
might cause trouble?
2. There's a private method `read_spacing_alist` in `one-page-breaking.cc` and
maybe that's not set up right? (Seems like it wouldn't build at all if that
were the case...) The other page breaking routines don't have any private
methods.
Attaching the patches in question and a test .ly file.
Incidentally, about the type warnings in the log[1] -- the code in
one-page-breaking.cc that calls Page_breaking::make_pages() is the same as the
code in minimal-page-breaking.cc, so either minimal-page-breaking.cc also
causes those type warnings, or maybe they are a result of whatever else is
going wrong.
[1]
> The log shows this:
>
> --snip--
>
> make[1]: *** [out/page-breaking-scheme.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> /tmp/lilypond-autobuild/lily/page-breaking.cc: In member function
> 'scm_unused_struct* Page_breaking::make_pages(std::
> vector<long unsigned int>, SCM)':
> /tmp/lilypond-autobuild/lily/page-breaking.cc:614:24: warning:
> conversion to 'int' from 'vsize {aka long unsigned int
> }' may alter its value [-Wconversion]
> int page_num = i + first_page_number;
> ^
> /tmp/lilypond-autobuild/lily/page-breaking.cc:617:55: warning:
> conversion to 'scm_t_int32 {aka int}' from 'long unsig
> ned int' may alter its value [-Wconversion]
> SCM line_count = scm_from_int (lines_per_page[i]);
>
> etc.
Attachments:
-
[0001-Issue-4752-1-Add-ly-one-page-breaking.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/dbe24292/1473/attachment/0001-Issue-4752-1-Add-ly-one-page-breaking.patch)
(9.8 kB; text/x-patch)
-
[0002-Issue-4752-2-Regtest-Doc-NR-4.3-Changes-entry.patch](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/dbe24292/1473/attachment/0002-Issue-4752-2-Regtest-Doc-NR-4.3-Changes-entry.patch)
(4.3 kB; text/x-patch)
-
[test.ly](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/dbe24292/1473/attachment/test.ly)
(1.4 kB; text/x-lilypond)
---
** [issues:#4752] Add ly:one-page-breaking**
**Status:** Started
**Created:** Sun Jan 24, 2016 06:22 PM UTC by Paul Morris
**Last Updated:** Thu Feb 04, 2016 06:16 AM UTC
**Owner:** Paul Morris
Add ly:one-page-breaking
includes regtest, doc entry, changes entry
http://codereview.appspot.com/288910043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
