- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for October 11th
---
** [issues:#4980] Fix issue where Musicxml2ly generates improper code for minor
chords**
**Status:** Started
**Created:** Mon Oct 03, 2016 11:37 AM UTC by pkx166h
**Last Updated:** Mon Oct 03, 2016 11:45 AM UTC
**Owner:** pkx166h
**Attachments:**
-
[chords.ly](https://sourceforge.net/p/testlilyissues/issues/4980/attachment/chords.ly)
(3.1 kB; text/x-lilypond)
-
[chords.xml](https://sourceforge.net/p/testlilyissues/issues/4980/attachment/chords.xml)
(31.0 kB; text/xml)
> Date: Thu, 18 Aug 2016 13:38:21 +0200
From: Johan Vromans <[email protected]>
To: David Kastrup <[email protected]>
Subject: Re: [PATCH] Eliminate accidental power chords in musicxml2ly.
Hi David,
On Thu, 18 Aug 2016 07:10:45 +0200
David Kastrup <[email protected]> wrote:
>> I'll prepare a better solution, which involves changing the way
>> ChordNameEvent (musicexp.py) handles modifications, but I'm going to
>> sleep first. Stay tuned.
>
> The 5 probably was a "lazy fix". You could probably replace it by 3.5
> but, well, I think I'd prefer a less ugly solution if you can reasonably
> come up with one.
Main reason I do not want the 3.5 workaround is that I wouldn't want my
major chords to look like c4:3.5...
Attached is a new patch. It patches scripts/musicxml2ly as before, with
r'{}' for a major chord.
The solutions for the invalid combinations are provided in
python/musicexp.py. A colon is added if a colon-less chord (i.e., major)
has modifications. Adding additions checks for a trailing digit, if none,
the leading period is omitted. Note that the changes in python/musicexp.py
are harmless to an un-patched scripts/musicxml2ly.
Also attached are chords.xml, a sheet of many chords based on the chart
from NR A.1, and chords.ly, the desired output after conversion. There are
a few discrepancies between the output from chords.ly and the chart from NR
A.1, but these occur in very weird chords so I consider these harmless.
Regards,
Johan
---
Fix issue where Musicxml2ly generates improper code for minor chords
The solutions for the invalid combinations
are provided in python/musicexp.py.
A colon is added if a colon-less chord
(i.e., major) has modifications. Adding
additions checks for a trailing digit,
if none, the leading period is omitted.
Note that the changes in python/musicexp.py
are harmless to an un-patched scripts/musicxml2ly.
http://codereview.appspot.com/305700043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
