Not intended to hold up the countdown but something I've been slightly worrying
about, so maybe double-check?
> (1) Line-thickness is improperly subtracted from the "off"
> value in Line_interface::make_dashed_line. This was done,
> presumably, to account for the line cap of each dash. In fact,
> PostScript discounts the line cap when constructing the pattern.
LilyPond stencil metrics need not map 1:1 to PostScript: I think that there
were some adjustments in this area either in the `scm/output-ps.scm` backend
code or even in the definitions in `ps/music-drawing-routines.ps`.
So it might be a good idea to add a regtest with quite thick lines and possibly
some tic marks/rulers/arrows added that would make it easy to verify the
assumptions visually.
---
** [issues:#5086] Fix dashed line errors**
**Status:** Started
**Created:** Tue Mar 07, 2017 04:45 AM UTC by David Nalesnik
**Last Updated:** Fri Mar 10, 2017 09:31 AM UTC
**Owner:** David Nalesnik
Fix dashed line errors
There are two errors in lily/line-interface.cc which cause
dashed lines to be drawn inaccurately.
(1) Line-thickness is improperly subtracted from the "off"
value in Line_interface::make_dashed_line. This was done,
presumably, to account for the line cap of each dash. In fact,
PostScript discounts the line cap when constructing the pattern.
(2) Dashed lines are constructed so that they begin and end
with a dash. Thus, a dashed line is built of dash + whitespace
units and a last lone dash. Period is not adjusted in
Line_interface::line for this last dash, which can lead to a
noticeable difference in its length compared to other dashes.
Correcting these flaws ensures that dashed lines end with a
dash rather than whitespace, and that terminating dashes are
not clipped. Also, the number of dashes drawn reflects the
number calculated.
http://codereview.appspot.com/320320043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
