You are missing a Rietveld review allowing for commenting on the patch details. 
 At any rate, I think this approach is far too ad-hoc.  You'd not get it 
accepted in the Linux kernel (which you claim to be your metric).  I rather 
propose that you instead allow color to be a list starting with a symbol.

Then you can set
color-function.film.ps = #(lambda (rest of list) ...)
to generate a string in the manner of "setcolor" in scm/output-ps.scm.  You can 
then set your colors as (cons 'film rest of list), if necessary through a 
callback.

When color-function.film does not exist, a color of (film ...) will lead to an 
error message at override time.  Otherwise, it may lead to an error message at 
output time (when there is no code for a particular backend).

This leads to useful extensibility, does not mess with the value checks (you'll 
just add more elements for your film color, depending on the particular 
application) and complains for a useful subset of undefined situations.


---

** [issues:#5162] Some hooks useful for video production**

**Status:** New
**Created:** Tue Jul 25, 2017 05:48 PM UTC by Knut Petersen
**Last Updated:** Tue Jul 25, 2017 05:48 PM UTC
**Owner:** Knut Petersen
**Attachments:**

- 
[0001-Implement-some-hooks-useful-for-producing-score-vide.patch](https://sourceforge.net/p/testlilyissues/issues/5162/attachment/0001-Implement-some-hooks-useful-for-producing-score-vide.patch)
 (7.7 kB; text/x-patch)


Producing ps or pdf documents intended to be used as
a source for video production requires some changes to
the output at a very late stage.

Often a page needs to repeated more than once with only
changes to some kind of progress bar / line or changes
to the color of a few grobs.

Parts of this postprocessing might be passed to postscript,
parts of this postprocessing might be done in the dump-page
procedure.

Therefore this patch provides a hook to write arbitrary
code to the prolog section of postscript output and a
hook to take over the dump-page process.

Using rgb values  < 0 and > 1 for grobs is an efficient
way to pass the information that, when and for how long
an object should change its color to a late state of
processing. Therefore a way to disable the range
check implemented in color? and to disable the precision
restriction in setrgbcolor is provided.



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to