---

** [issues:#5374] Remove Grob_info::origin_contexts ()**

**Status:** Started
**Created:** Sat Jul 07, 2018 04:10 PM UTC by David Kastrup
**Last Updated:** Sat Jul 07, 2018 04:10 PM UTC
**Owner:** nobody


Remove Grob_info::origin_contexts ()

I cannot believe this: this function is obscure both in definition and
usage.  Most uses were completely nonsensical, and one use just an
overly complex method of achieving a semi-random goal.

I cannot figure out what the original aim of the respective code
passages was, but whatever it was, seemingly other workarounds took
its place successfully.


Also contains some preparatory commits:

Remove Grob_info::origin_contexts ().size () uses

The size of Grob_info::origin_contexts () was used several times as a flag,
but the function could never return an empty array anyway.


Sanitize Break_align_engraver::create_alignment source

Break_align_engraver went to some contortions to get an engraver from
the same context as the grob it acknowledged.  There is no real point
in it not just using the origin engraver for that purpose, however.

http://codereview.appspot.com/342210043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • [Lilypond-... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto
    • [Lily... Auto mailings of changes to Lily Issues via Testlilyissues-auto

Reply via email to