- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
Change \partcombine (et al.) to \partCombine master staging
author Valentin Villenave <[email protected]>
Fri, 28 Dec 2018 09:14:40 +0000 (10:14 +0100)
committer Valentin Villenave <[email protected]>
Fri, 28 Dec 2018 09:14:40 +0000 (10:14 +0100)
commit 72067b395d947f1349ab8010f0592d45e52b8141
~~~
---
** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h
**Last Updated:** Thu Dec 27, 2018 09:13 AM UTC
**Owner:** Valentin Villenave
On 13/08/15 21:42, Malte Meyn wrote:
> Hi list,
>
> the case of the ‘c’ in partcombine is inconsistent, confusing me every
> time I use \partcombine(Apart|Chords|…):
>
> \partcombine, \partcombineApart, … but
> \partCombineTextsOnNote, \partCombineListener
>
> I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’.
>
> Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the
> engravers which use the more ‘natural’ underscore instead of camelCase
> for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that
> ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not
> ‘cueclefGlyph’), ‘Part_combine_engraver’ does.
>
> I think that this would be rather easy to change.
>
> Cheers,
> Malte
New Rietveld - http://codereview.appspot.com/369930043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
