- **Needs**: -->
- **Patch**: new --> needs_work
- **Type**: --> Enhancement
- **Comment**:
Seems to fail make check
../regression/note-names-context.ly'
~~~
Processing `./96/lily-8e4f4d10.ly'
Parsing...
Renaming input to:
`/home/james/lilypond-git/input/regression/note-names-context.ly'
Interpreting music...Backtrace:
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1044: 3 (let* ((failed #) (separate-logs #) (ping-log #) ...) (gc) ...)
1056: 4* [for-each #<procedure #f #> #]
In unknown file:
?: 5* [#<procedure #f (x)> "96/lily-8e4f4d10.ly"]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1058: 6* (let* (# # #) (if separate-logs #) (if ping-log #) ...)
1069: 7* [lilypond-file #<procedure #f (key failed-file)>
"96/lily-8e4f4d10.ly"]
1104: 8 [catch ly-file-failed #<procedure #f ()> #<procedure #f (x . args)>]
In unknown file:
?: 9* [#<procedure #f ()>]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1105: 10* [ly:parse-file "96/lily-8e4f4d10.ly"]
In /home/james/lilypond-git/build/out/share/lilypond/current/ly/init.ly:
56: 11* (let* ((book-handler #)) (cond (# #) (# #)))
59: 12 (cond (# #) (# #))
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily-library.scm:
...
247: 13 [ly:book-process-to-systems #<Book> #< Output_def> ...]
In unknown file:
?: 14* [# #]
?: 15* [# # #]
?: 16* [#<Callback0_wrapper> #<Translator Note_name_engraver >]
?: 17* [note-name-strings #<Pitch c' > #<Context NoteNames () >]
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/translation-functions.scm:
888: 18* (let* (# # # # ...) (if oct-style # str))
892: 19* (if (not (null? lang)) (note-name->string pitch (string->symbol
lang)) ...)
894: 20 [note-name->string #<Pitch c' >]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:
67: 21 (let* ((pitch-alist #) (result #)) (if result (symbol->string #)))
71: 22* (rassoc pitch (filter (lambda (p) (eq? # 0)) pitch-alist) ...)
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
In expression (rassoc pitch (filter # pitch-alist) ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
Unbound variable: rassoc
~~~
../accidental-single-double.ly
~~~
Renaming input to:
`/home/james/lilypond-git/input/regression/accidental-single-double.ly'
Interpreting
music.../home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
In expression (rassoc pitch (filter # pitch-alist) ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
Unbound variable: rassoc
~~~
../page-spacing-nonstaff-lines-between-systems.ly
~~~
Renaming input to:
`/home/james/lilypond-git/input/regression/page-spacing-nonstaff-lines-between-systems.ly'
Interpreting
music.../home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
In expression (rassoc pitch (filter # pitch-alist) ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-name.scm:71:18:
Unbound variable: rassoc
~~~
---
** [issues:#1367] Enhancement: NoteNames context should handle any note names
language**
**Status:** Started
**Created:** Wed Oct 27, 2010 02:45 PM UTC by Anonymous
**Last Updated:** Mon Feb 11, 2019 10:42 PM UTC
**Owner:** Valentin Villenave
**Attachments:**
-
[bug.preview.png](https://sourceforge.net/p/testlilyissues/issues/1367/attachment/bug.preview.png)
(1.9 kB; image/png)
*Originally created by:* *anonymous
*Originally created by:* [v.villenave](http://code.google.com/u/v.villenave/)
*Originally owned by:* [v.villenave](http://code.google.com/u/v.villenave/)
As Mats noticed a few years ago, default \(Nederlands\) note names are
hardcoded in the Note\_names\_engraver: in the following example, the notes are
entered in Spanish but printed in Dutch.
[http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html](http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html)
\version "2.13.37"
\include "espanol.ly"
notes = \relative do' \{ do re mi do \}
\new Staff <<
\notes
\context NoteNames \{ \notes \}
>>
It would be more elegant to use the pitchnames variable \(just like
\displayLilyMusic does\) so we could print note names in any language.
--
Valentin Villenave - 2019-02-02
OK, here’s a (I hope) much better patch that not only deals with the
Note_name_engraver, but also aims to make all of the note-/pitch-naming
functions more consistent and flexible (including in chord names). Included is
a regtest showing off the new capabilities offered by this engraver, including
quite a few user-settable properties and Scheme functions. (Documentation is
not included yet though, as I’d like to first settle on an agreed feature set,
property names and general mechanism.)
Please let me know if you think I’m on the right track here:
https://codereview.appspot.com/221710044/#ps60001
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
