- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
Pushed to staging as
~~~
commit bdd9f912691797b954e9541b03f25dfccc1291a2
Author: Jonas Hahnfeld <[email protected]>
Date: Thu Nov 7 22:23:30 2019 +0100
Issue 5597: musicxml: Use method to get number of Lyric
Commit edb29ef3a ("Correct an inconsistency in the Lyric class")
renamed the method from get_number() to number(), which is shadowed
by the attribute itself and not used in the current code. Using a
method has the advantage that the code can cast to int() in a single
place which is needed for Python 3. Additionally, the code handles
the case if there is no 'number' attribute (should this ever happen).
~~~
---
** [issues:#5597] musicxml: Use method to get number of Lyric**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Thu Nov 07, 2019 09:35 PM UTC by Jonas Hahnfeld
**Last Updated:** Mon Nov 11, 2019 01:54 PM UTC
**Owner:** Jonas Hahnfeld
musicxml: Use method to get number of Lyric
Commit edb29ef3a ("Correct an inconsistency in the Lyric class")
renamed the method from get_number() to number(), which is shadowed
by the attribute itself and not used in the current code. Using a
method has the advantage that the code can cast to int() in a single
place which is needed for Python 3. Additionally, the code handles
the case if there is no 'number' attribute (should this ever happen).
http://codereview.appspot.com/573230043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
