- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
```text
commit 000d9cfc986c2b8a4f7f0ffdfbbe25aeed1bac63
Author: Dan Eble <[email protected]>
Date: Mon Nov 18 10:02:30 2019 -0500
Issue 5607/2: typedef System::rank_type
...
commit 1e11c0a21f2003800165b138a5eaf9e0d88a3df7
Author: Dan Eble <[email protected]>
Date: Mon Nov 18 10:02:30 2019 -0500
Issue 5607/1: break-substitution: typedef System_range to clarify code
...
```
---
** [issues:#5607] typedef System::rank_type**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Nov 19, 2019 05:35 PM UTC by Dan Eble
**Last Updated:** Mon Nov 25, 2019 12:13 PM UTC
**Owner:** Dan Eble
1. break-substitution: typedef System_range to clarify code
Call an interval of System rank a "System_range" rather than a "Slice."
Though both of these are currently Interval_t<int>, there is code that
stores System ranks in shorts. At some point, it might make sense to
change System_range to Interval_t<short> for consistency.
2. typedef System::rank_type
Code in break-substitution.cc previously assumed that there would not
be more than 32k systems. This centralizes that assumption in System
and checks for programming errors.
https://codereview.appspot.com/581270043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
