- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Needs**: -->
- **Patch**: new -->
- **Type**: --> Maintainability
- **Comment**:
Pushed to staging as:
~~~
commit 9926ad3e43ab99c7463ca646fd4321647a9d72da
Author: Jonas Hahnfeld <[email protected]>
Date: Tue Nov 19 18:56:26 2019 +0100
Issue 5608/2: Fix struct vs. class template for PQueue
Clang issues a warning that this could be an issue for the
"Windows C++ ABI". Apparently, that's not really causing problems
as the mismatch was introduced by commit c8989177a in 1997...
commit 0b62028523d8d81cbc81b48ce10d14d9f680510c
Author: Jonas Hahnfeld <[email protected]>
Date: Tue Nov 19 18:55:29 2019 +0100
Issue 5608/1: Fix warning flag detection for Clang
Clang requires -Werror=unknown-warning-option to actually throw an
error if it doesn't know about a warning flag.
~~~
---
** [issues:#5608] Avoid easy warnings with Clang**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Nov 19, 2019 06:53 PM UTC by Jonas Hahnfeld
**Last Updated:** Mon Nov 25, 2019 05:34 PM UTC
**Owner:** Jonas Hahnfeld
Avoid easy warnings with Clang
Building with Clang is currently a lot nosier than with GCC. This
represents a first step into the right direction by picking the
low-hanging fruits.
1. Fix warning flag detection for Clang
Clang requires -Werror=unknown-warning-option to actually throw an
error if it doesn't know about a warning flag.
2. Fix struct vs. class template for PQueue
Clang issues a warning that this could be an issue for the
"Windows C++ ABI". Apparently, that's not really causing problems
as the mismatch was introduced by commit c8989177a in 1997...
http://codereview.appspot.com/573270043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
