- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
Pushed to staging as
commit b577dabf80990b4ba08ccfd5f6dc3874638fe49e
Author: Werner Lemberg <[email protected]>
Date: Sat Nov 23 21:52:37 2019 +0100
Issue 5618: configure: fix compiler warnings in tests
The `configure` script sets up a small header file `confdefs.h` for tests;
we add a hack to undefine macro `PACKAGE_NAME`, which gets defined twice for
historical reasons, and which causes compiler warnings without this change.
---
** [issues:#5618] configure: Fix tests for compiler warning flags.**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Sat Nov 23, 2019 09:03 PM UTC by Werner LEMBERG
**Last Updated:** Mon Dec 02, 2019 08:09 AM UTC
**Owner:** Werner LEMBERG
`AC_LANG_PROGRAM` ignores compiler warnings. This behaviour made the tests
always true and thus without any effect. We now add `-Werror` to enforce an
error in case the warning flag is not known.
To make that work it is also necessary to compile `confdefs.h` without
warnings; we add a hack to undefine macro `PACKAGE_NAME`, which gets defined
twice for historical reasons.
https://codereview.appspot.com/551210043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
