Here's the regtest difference.   Previously, the bracket did not extend to the 
first staff.


Attachments:

- 
[rest-positioning.compare.jpeg](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/3e2e5f597f/0a21/attachment/rest-positioning.compare.jpeg)
 (90.6 kB; image/jpeg)


---

** [issues:#5629] Staff_symbol clean-up**

**Status:** Started
**Created:** Fri Dec 06, 2019 05:13 PM UTC by Dan Eble
**Last Updated:** Fri Dec 06, 2019 05:16 PM UTC
**Owner:** Dan Eble


1: Reduce unnecessary access to line-positions property

In some places, Staff_symbol had already checked line-positions before calling 
line_count (), which checked it again.

2: Remove unused Staff_symbol::line_count () and 
Staff_symbol_referencer::line_count ()

3: Use ly_scm2floatvector () in Staff_symbol::line_positions ()

4: Make height of a no-line staff [0, 0] rather than empty

This fixes a bug in the output of input/regression/rest-positioning.ly, in 
which a staff-group bracket failed to extend to a no-line staff.

https://codereview.appspot.com/571210043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to