- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
Due to the lack of confident feedback, I've pushed the changes without the
unpure-pure container because they are simpler. I also don't want to set a
precedent for using an unpure-pure container on an X-axis thing when I'm not
confident that it is necessary.
If problems are discovered later, we can try this idea mentioned in the code
review:
```scheme
;; It's not clear whether having a pure version of
;; self-alignment-X is necessary or beneficial.
(self-alignment-X . ,(ly:make-unpure-pure-container
break-alignable-interface::self-alignment-opposite-of-anchor
CENTER))
```
Pushed to staging:
```text
commit 964ed7f8eda237062f15e5fdb38bd38aa96e063f (HEAD, origin/staging)
Author: Dan Eble <[email protected]>
Date: Sat Dec 14 16:11:25 2019 -0500
Issue 5621/4: Improve rehearsal mark position at beginning of staff
RehearsalMark uses a callback for self-alignment-X that yields the
opposite of the direction specified by the anchor grob.
commit 139f567e3199841b00e0690c7bb27ca2e6ec5210
Author: Dan Eble <[email protected]>
Date: Mon Dec 16 23:08:03 2019 -0500
Issue 5621/3: let MAKE_SCHEME_CALLBACK... handle overloading
commit 25d19ca596a9d39038c8f15040621fe92bba0dd2
Author: Dan Eble <[email protected]>
Date: Sun Dec 15 19:03:01 2019 -0500
Issue 5621/2: explicitly align rehearsal mark in pedal-bracket test
The mark is obviously intended to test the extent of the pedal bracket.
It is not clear whether it matters that the mark extends to the left as
well as to the right, but to be safe, explicitly center it so that
future changes to the default alignment do not affect this test.
commit 9d2d9e12d691600eaa9fd7b13d002273b123811a
Author: Dan Eble <[email protected]>
Date: Sun Dec 15 15:20:44 2019 -0500
Issue 5621/1: remove old RehearsalMark regression tests
These test cases were described as covering marks on invisible bar
lines. Judging from the current implementation, it seems that this was
a detail of a prior implementation. These tests do not seem to add any
value over the other tests we have.
```
---
** [issues:#5621] Improve positioning of rehearsal marks at the beginning of
staff**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Nov 26, 2019 11:44 AM UTC by Werner LEMBERG
**Last Updated:** Sun Jan 05, 2020 01:33 PM UTC
**Owner:** Dan Eble
I suggest to change the default value of the `break-align-anchor-alignment`
property from the `Clef` grob from `RIGHT` to value 2, as shown in the images.
~~~~
{
f'1 | f'1 | \break
\mark \default f'1 | f'1 |
}
~~~~
Dan's Patch (supercede's Werners) -
https://codereview.appspot.com/547340043
Werner's Original Patch is here:
https://codereview.appspot.com/553290043
See latest comment below for links to reg test diffs.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
