- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for January 25th, I know the comments on Rietveld are in
discussion but I'll leave this on countdown for now.
---
** [issues:#4550] Avoid "using" directives in included files**
**Status:** Started
**Created:** Mon Aug 10, 2015 10:02 AM UTC by Anonymous
**Last Updated:** Wed Jan 22, 2020 03:13 PM UTC
**Owner:** Dan Eble
*Originally created by:* *anonymous
*Originally created by:*
[[email protected]](http://code.google.com/u/107439649205250398889/)
*Originally owned by:*
[[email protected]](http://code.google.com/u/107439649205250398889/)
"using namespace std;" seems to be \*everywhere\* in Lilypond. It appears in
\*.cc files before headers are included. It appears in header files too.
"using" directives should not be used where they might affect more than the
current file.
The patch for this issue will have to wait for a handful of issues that I found
along the way to be fixed, but here is the summary:
\* eliminate "using namespace std;"
\* add "std::" to everything in \*.hh files \(and other included files\)
\* add "using std::whatever;" in \*.cc files for common types \(e.g. string,
vector\)
\* add "std::" in \*.cc files for functions \(e.g. swap\) and other less
common things \(e.g. less\)
Latest attempt: https://codereview.appspot.com/579240043/
Earlier attempts: <strike> https://codereview.appspot.com/254670043/ </strike>
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
