- Description has changed:
Diff:
~~~~
--- old
+++ new
@@ -1,12 +1,23 @@
-Generalize context searches
+1: Add Context::matches ()
-Combine code for \new, \context, and various internal searches. This includes
a small block of disabled code which will fix
input/regression/context-find-parent.ly once it is enabled.
+This method answers the central question of a context search: is this
+what I'm looking for? Its use will increase in later commits.
-Separate the following from the act of finding a context:
-1. forbid access to the Global context
-2. prevent creation of multiple Scores under the Global context
-3. warn if the desired context is not found or created
+2: Generalize context searches
-Rename the music property descend-only to search-direction; change its type
from a boolean to a direction.
+Combine code for \new, \context, and various internal searches. This
+includes a small block of disabled code which will fix
+input/regression/context-find-parent.ly once it is enabled.
-http://codereview.appspot.com/344050043
+input/regression/context-descend-only-not-found.ly shows that a defect
+in the descend-to-context function has been fixed: although the
+previous implementation never changed context outside the current
+subtree, it allowed creating a new context outside the current
+subtree.
+
+3: Change descend-only to search-direction
+
+It is now a direction rather than a boolean.
+
+Current review: https://codereview.appspot.com/579250043/
+Old review: <strike> http://codereview.appspot.com/344050043 </strike>
~~~~
- **Needs**: -->
- **Type**: --> Enhancement
---
** [issues:#5362] Generalize context searches**
**Status:** Started
**Created:** Fri Jun 29, 2018 01:08 AM UTC by Dan Eble
**Last Updated:** Wed Jan 29, 2020 08:34 PM UTC
**Owner:** Dan Eble
1: Add Context::matches ()
This method answers the central question of a context search: is this
what I'm looking for? Its use will increase in later commits.
2: Generalize context searches
Combine code for \new, \context, and various internal searches. This
includes a small block of disabled code which will fix
input/regression/context-find-parent.ly once it is enabled.
input/regression/context-descend-only-not-found.ly shows that a defect
in the descend-to-context function has been fixed: although the
previous implementation never changed context outside the current
subtree, it allowed creating a new context outside the current
subtree.
3: Change descend-only to search-direction
It is now a direction rather than a boolean.
Current review: https://codereview.appspot.com/579250043/
Old review: <strike> http://codereview.appspot.com/344050043 </strike>
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
