OK so the process is (ignoring the -j and CPU_COUNT switches for clarity):
~~~
cd $LILYPOND_GIT
mkdir build
./autogen.sh --noconfigure
cd build
../configure --disable-optimising
make
make test-baseline
cd ..
~~~
Now I apply patch using:
~~~
git apply --index [path to diff from Rietveld]
~~~
Now since last week I do this:
~~~
  cd build
  ./config.status --recheck
  touch config.hh
~~~
Then I run 
~~~
cd ..
./scripts/auxiliar/makelsr.py
~~~
This covers any 'snippets/new' type patches
and finally:
~~~
make clean
make
make check
make doc
~~~
Done.

According to my primitive 'where am I in the process?' logging - which is just 
a bunch of 'echo' commands to a text file saying when each step completes (and 
how long it took) this patch fails at some point in the make check stage.

Yet if I start with a clean tree, apply the patch and build LP, test-baselines 
and all doc with seperate make commands (and nothing else) it all works.

It fails in make check with this (I apologies for the longish output):

~~~
...
Making input/regression/lilypond-book/out-test/texinfo-papersize-docs.pdf < texi
comparing input/regression/out-test-baseline
       to input/regression/out-test
  2100 signature
  1349 log
  1348 profile
     1 gittxt
  4798 total
comparing input/regression/midi/out-test-baseline
       to input/regression/midi/out-test
    30 signature
    39 midi
    31 log
    30 profile
   130 total
comparing input/regression/midi/out-test-baseline/recovered
       to input/regression/midi/out-test/recovered
     0 total
no source for input/regression/out-test/collated-files.texilog.log
no source for input/regression/out-test/tree.gittxt
no source for input/regression/midi/out-test/dynamic-initial-1.midi
no source for input/regression/midi/out-test/sequence-name-1.midi
no source for input/regression/midi/out-test/sequence-name-2.midi
no source for input/regression/midi/out-test/sequence-name-3.midi
no source for input/regression/midi/out-test/sequence-name-scoping-1.midi
no source for input/regression/midi/out-test/sequence-name-scoping-2.midi
no source for input/regression/midi/out-test/sequence-name-scoping-3.midi
no source for input/regression/midi/out-test/sequence-name-scoping-4.midi
no source for input/regression/midi/out-test/sequence-name-scoping-5.midi
no source for input/regression/midi/out-test/collated-files.texilog.log
Traceback (most recent call last):
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1602, in <module>
    main ()
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1599, in main
    compare_tree_pairs (list(zip(args[0::2], args[1::2])), out, 
options.threshold)
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1300, in compare_tree_pairs
    data.print_results (threshold)
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1292, in print_results
    self.write_text_result_page ('', threshold)
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1077, in write_text_result_page
    (changed, below, unchanged) = self.thresholded_results (threshold)
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1055, in thresholded_results
    for link in list(self.file_links.values ())]
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
1055, in <listcomp>
    for link in list(self.file_links.values ())]
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
396, in distance
    self._distance = self.calc_distance ()
  File "/home/james/lilypond-git/build/scripts/build/out/output-distance", line 
537, in calc_distance
    cont0 = self.contents[0].strip();
AttributeError: 'NoneType' object has no attribute 'strip'
/home/james/lilypond-git/build/../GNUmakefile.in:376: recipe for target 
'local-check' failed
make: *** [local-check] Error 1
~~~

This failure is also seen on the other 'make' patches in countdown (issues 
5782, 5785 and 5786 for example). Yet all three also pass in the smae way as 
mentioned above


---

** [issues:#5785] texinfo-rules: generate log files in $(outdir)/**

**Status:** Started
**Created:** Sat Feb 22, 2020 11:22 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon Feb 24, 2020 03:07 PM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/557480043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to