pushed to `staging` as
~~~
commit 350da6659902d38fc305c0b25c9e7659f8108563
Author:     Jonas Hahnfeld <[email protected]>
AuthorDate: Thu Feb 20 12:27:29 2020 +0100
Commit:     Jonas Hahnfeld <[email protected]>
CommitDate: Tue Feb 25 09:58:13 2020 +0100

    Issue 5776/3: Drop check for explicit template instantiation
    
    The define was unused and as far as I can tell, the code is valid
    C++ and should just always work.

commit 8a1ebfb93100ecda500016bb2f3e328b8add3b54
Author:     Jonas Hahnfeld <[email protected]>
AuthorDate: Sun Feb 16 11:15:59 2020 +0100
Commit:     Jonas Hahnfeld <[email protected]>
CommitDate: Tue Feb 25 09:58:09 2020 +0100

    Issue 5776/2: flower: Rely on [v]snprintf from libc
    
    These are required in C++11 according to
    https://en.cppreference.com/w/cpp/io/c/fprintf
    https://en.cppreference.com/w/cpp/io/c/vfprintf
    
    While editing config.hh.in, also get rid of unused HAVE_LRINT.

commit b51e6224ab6bf888edb68e45dd6f7a128c4d12a6
Author:     Jonas Hahnfeld <[email protected]>
AuthorDate: Sun Feb 16 11:09:15 2020 +0100
Commit:     Jonas Hahnfeld <[email protected]>
CommitDate: Tue Feb 25 09:58:03 2020 +0100

    Issue 5776/1: Drop check for std::vector::data()
    
    The corresponding code was already removed in 2015, commit d36ec1303b
    ("Issue 4577: Remove the nasty workaround for platforms that don't
    provide std::vector::data().").
~~~


---

** [issues:#5776] Remove redundant checks with C++11**

**Status:** Started
**Created:** Thu Feb 20, 2020 11:40 AM UTC by Jonas Hahnfeld
**Last Updated:** Mon Feb 24, 2020 07:48 PM UTC
**Owner:** Jonas Hahnfeld


Remove redundant checks with C++11

Individual changes:
1) Drop check for std::vector::data()

The corresponding code was already removed in 2015, commit d36ec1303b
("Issue 4577: Remove the nasty workaround for platforms that don't
provide std::vector::data().").

2) flower: Rely on [v]snprintf from libc

These are required in C++11 according to
https://en.cppreference.com/w/cpp/io/c/fprintf
https://en.cppreference.com/w/cpp/io/c/vfprintf

While editing config.hh.in, also get rid of unused HAVE_LRINT.

3) Drop check for explicit template instantiation

The define was unused and as far as I can tell, the code is valid
C++ and should just always work.

http://codereview.appspot.com/583550043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to