- **Patch**: review --> countdown
- **Type**: --> Maintainability
- **Comment**:
Patch on countdown for March 13th
---
** [issues:#5829] Re-indent all mf files**
**Status:** Started
**Created:** Sat Mar 07, 2020 09:22 AM UTC by Torsten Hämmerle
**Last Updated:** Mon Mar 09, 2020 01:50 PM UTC
**Owner:** Torsten Hämmerle
https://codereview.appspot.com/573610048
Now that Werner has banned all tabs from mf files, initially replacing them by
8 spaces each, it's time for the second step:
> **lemzwerg 2020/02=29 17:23:39**
> We could later decide to reduce the indentation to two (or four) spaces –
> which I like much better. However, this would be a lot of work and is
> probably not worth the trouble.
# Design question: 2 or 4 character-indent?
1. Applying a general indent of 2 or 4 characters to mf files will be less
wasteful and better matches the usual 2 or 4 character indent used throughout.
2. having saved quite a lot of space, ident fet_begingroup [...] fet_endgroup,
too?
### Examples for **Question 2**:
**mf/accidentals.mf (current)** already used indentation for fet_begringroup
[...] fet_endgroup`
~~~~
fet_begingroup ("accidentals");
input feta-arrow;
input feta-sharps;
input feta-naturals;
input feta-flats;
input feta-parenthesis;
fet_endgroup ("accidentals");
~~~~
**mf/accidentals.mf (new)** (reduced to, say, 2 characters)
~~~~
fet_begingroup ("accidentals");
input feta-arrow;
input feta-sharps;
input feta-naturals;
input feta-flats;
input feta-parenthesis;
fet_endgroup ("accidentals");
~~~~
But, in contrast to that, most of the times, there was no fet_begingroup [...]
fet_endgroup indent at all, e.g.:
**mf/feta-pedals.mf (current)**
~~~
[...]
fet_begingroup ("pedal");
pedalpha = 40;
pedbeta = 25;
[...]
~~~
**mf/feta-pedals.mf (new)**
~~~
[...]
fet_begingroup ("pedal");
pedalpha = 40;
pedbeta = 25;
[...]
~~~
## Scope
Out of the currentyl 201 \*.mf files, 59 do not have any indentation and thus
need not be changed.
The remaining 43 files will be re-formatted on semi-automatic.
## Adapt Contributor's guide METAFONT fomatting rules
The [13.6 METAFONT formatting
rules](http://lilypond.org/doc/v2.19/Documentation/contributor/metafont-formatting-rules)
still mention tabs. This should be changed and adapted, depending on the
design descision taken and implemented here.
#Decision: 2 char indent
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto