- **Patch**: review --> push
- **Comment**:
Patch counted down - please push
(@Hanwen, what I meant was that by using, I assume git-cl, the issue was set
back to 'New', so all i was saying was that i'll review it on the next
countdown as 'not new' - i.e. you can now push it).
---
** [issues:#5938] Thread skyline construction through stencil interpretation**
**Status:** Started
**Created:** Sat Apr 25, 2020 11:42 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 01, 2020 10:53 AM UTC
**Owner:** Han-Wen Nienhuys
Before, we'd convert stencils to a combination of boxes and buildings,
and afterwards convert those to skylines.
The new approach has the following advantages:
* We can convert stencils to line segments directly, allowing for more
precise outlines, and reduced memory overhead
* We can treat line thicknesses much more simply: we just extend line
segments by 0.5 thicknesses on either side, and add them .5
thickness up and down.
A next improvement is to thread Lazy_skyline_pair through to the glyph
outline generation. This would let us cut back on memory use for path
storage, and reduce the number of paths by 2x (the orientation of the
outline segments tells us if they are for the up or down skyline.)
Formatting impact:
The regtest shows 114 differences. The improved skylines lead to
slightly denser formatting, both horizontally and vertically. In
particular, some accidental configurations become very cramped (eg
accidental-placement.ly)
Timing impact: TODO
https://codereview.appspot.com/581960043
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
