- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 96b0e346adebe12ac742044c02cc8c2152e89977
Author:     Han-Wen Nienhuys <[email protected]>
AuthorDate: Sat May 2 09:31:13 2020 +0200
Commit:     Han-Wen Nienhuys <[email protected]>
CommitDate: Fri May 8 09:13:08 2020 +0200

    Convert stencil to skyline directly
    
    Gets rid of more intermediate storage.
    
    eb3e0449f4 - Convert stencil to skyline directly
      baseline: 78d4ae8627 Thread skyline construction through stencil 
interpretation
      args: -I carver MSDM
      memory: med diff -1464 (stddevs 202 98, n=3)
      memory: med diff -0.1 % (eb3e0449f4 is leaner)
      time: med diff 0.10 (stddevs 0.09 0.06, n=3)
      time: med diff 0.2 % (eb3e0449f4 is neutral)
~~~

and

~~~
commit 9e69d5c5e19458bde7a413d7c3e4d3e0ec3060d4
Author:     Han-Wen Nienhuys <[email protected]>
AuthorDate: Fri May 8 09:12:55 2020 +0200
Commit:     Han-Wen Nienhuys <[email protected]>
CommitDate: Fri May 8 09:15:14 2020 +0200

    Convert stencil to skyline directly
    
    Gets rid of more intermediate storage.
    
    f7d164b888 - Convert stencil to skyline directly
      baseline: 267e894e79 Thread skyline construction through stencil 
interpretation
      args: -I carver MSDM
      memory: med diff -1068 (stddevs 84 90, n=5)
      memory: med diff -0.1 % (f7d164b888 is leaner)
      time: med diff -0.18 (stddevs 0.15 0.05, n=5)
      time: med diff -0.4 % (f7d164b888 is neutral)
~~~
(the latter applying the changes I requested during review)



---

** [issues:#5943] Convert stencil to skyline directly**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun Apr 26, 2020 12:13 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:50 AM UTC
**Owner:** Han-Wen Nienhuys


Gets rid of more intermediate storage.

Benchmarks show that this is performance neutral.

https://codereview.appspot.com/555760043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to