On Sat, 28 Feb 2004, Han-Wen Nienhuys wrote:

> [EMAIL PROTECTED] writes:
> >
> > Why not to have commands \arpeggioup and \arpeggiodown?
> > They would be handy.
>
> Go ahead.
> Please consider the capitalization standards, though.

I made functions \arpeggioUp, \arpeggioDown, \arpeggioBoth and
\arpeggioBracket, which all work like \slurUp etc.

Function \arpeggioBracket was redefined. Therefore, I should ask whether
this is ok?

The patch is as an attachment.

Greetings,

  Heikki Junes
Index: VERSION
===================================================================
RCS file: /cvsroot/lilypond/lilypond/VERSION,v
retrieving revision 1.548
diff -u -r1.548 VERSION
--- VERSION     25 Feb 2004 14:43:52 -0000      1.548
+++ VERSION     28 Feb 2004 23:35:53 -0000
@@ -2,5 +2,5 @@
 MAJOR_VERSION=2
 MINOR_VERSION=1
 PATCH_LEVEL=27
-MY_PATCH_LEVEL=hwn1
+MY_PATCH_LEVEL=hjj1
 
Index: ChangeLog
===================================================================
RCS file: /cvsroot/lilypond/lilypond/ChangeLog,v
retrieving revision 1.1790
diff -u -r1.1790 ChangeLog
--- ChangeLog   28 Feb 2004 19:37:41 -0000      1.1790
+++ ChangeLog   28 Feb 2004 23:35:54 -0000
@@ -1,3 +1,13 @@
+2004-02-29  Heikki Junes <[EMAIL PROTECTED]>
+
+       * ly/property-init: new functions: \arpeggioUp, \arpeggioDown,
+       \arpeggioBoth. redefine \arpeggioBracket.
+
+       * Documentation/user/refman.itely: document new arpeggio
+       functions.
+
+       * input/regression/arpeggio-bracket.ly: use new \arpeggioBracket.
+
 2004-02-28  Han-Wen Nienhuys   <[EMAIL PROTECTED]>
 
        * scm/*.scm: make-music-by-name is replaced by make-music, which
Index: ly/property-init.ly
===================================================================
RCS file: /cvsroot/lilypond/lilypond/ly/property-init.ly,v
retrieving revision 1.46
diff -u -r1.46 property-init.ly
--- ly/property-init.ly 28 Feb 2004 19:37:41 -0000      1.46
+++ ly/property-init.ly 28 Feb 2004 23:35:54 -0000
@@ -131,8 +131,25 @@
 % of either Staff.Arpeggio or PianoStaff.Arpeggio, depending whether 
 % cross-staff brackets are desired. 
 
-arpeggioBracket = #Arpeggio::brew_chord_bracket
 arpeggio = #(make-music 'ArpeggioEvent)
+% HJJ: deprecated: arpeggioBracket = #Arpeggio::brew_chord_bracket
+
+arpeggioUp = \sequential {
+  \revert Arpeggio  #'print-function
+  \override Arpeggio  #'arpeggio-direction = #1
+}
+arpeggioDown = \sequential {
+  \revert Arpeggio  #'print-function
+  \override Arpeggio  #'arpeggio-direction = #-1
+}
+arpeggioBoth = \sequential {
+  \revert Arpeggio  #'print-function
+  \revert Arpeggio  #'arpeggio-direction
+}
+arpeggioBracket = \sequential {
+  \override Arpeggio  #'print-function = #Arpeggio::brew_chord_bracket
+}
+
 glissando = #(make-music 'GlissandoEvent)
 
 fermataMarkup = \markup { \musicglyph #"scripts-ufermata" } 
Index: Documentation/user/refman.itely
===================================================================
RCS file: /cvsroot/lilypond/lilypond/Documentation/user/refman.itely,v
retrieving revision 1.454
diff -u -r1.454 refman.itely
--- Documentation/user/refman.itely     27 Feb 2004 11:18:17 -0000      1.454
+++ Documentation/user/refman.itely     28 Feb 2004 23:35:55 -0000
@@ -3172,36 +3172,37 @@
 @end lilypond
 
 The direction of the arpeggio is sometimes denoted by adding an
-arrowhead to the wiggly line.  This can be typeset by setting
[EMAIL PROTECTED]:
+arrowhead to the wiggly line:
 
 @lilypond[fragment,relative,verbatim]
   \context Voice {
-     \override Arpeggio   #'arpeggio-direction = #1
+     \arpeggioUp
      <c e g c>\arpeggio
-     \override Arpeggio   #'arpeggio-direction = #-1
+     \arpeggioDown
      <c e g c>\arpeggio
   }
 @end lilypond
 
 A square bracket on the left indicates that the player should not
-arpeggiate the chord. To draw these brackets, set the
[EMAIL PROTECTED] property of @code{Arpeggio} or
[EMAIL PROTECTED] objects to @code{\arpeggioBracket}, and use
[EMAIL PROTECTED] statements within the chords as before:
+arpeggiate the chord:
 
 @lilypond[fragment,relative,verbatim]
-    \override PianoStaff.Arpeggio  
-        #'print-function = \arpeggioBracket
-       <c' e g c>\arpeggio
+     \arpeggioBracket
+    <c' e g c>\arpeggio
 @end lilypond
 
 @refcommands
 
[EMAIL PROTECTED] @code{\arpeggioBracket}
[EMAIL PROTECTED], 
 @cindex @code{\arpeggio}
[EMAIL PROTECTED]
[EMAIL PROTECTED],
[EMAIL PROTECTED] @code{\arpeggioUp}
[EMAIL PROTECTED],
[EMAIL PROTECTED] @code{\arpeggioDown}
[EMAIL PROTECTED],
[EMAIL PROTECTED] @code{\arpeggioBoth}
[EMAIL PROTECTED],
[EMAIL PROTECTED] @code{\arpeggioBracket}
[EMAIL PROTECTED]
 
 @seealso
 
Index: input/regression/arpeggio-bracket.ly
===================================================================
RCS file: /cvsroot/lilypond/lilypond/input/regression/arpeggio-bracket.ly,v
retrieving revision 1.6
diff -u -r1.6 arpeggio-bracket.ly
--- input/regression/arpeggio-bracket.ly        22 Feb 2004 21:47:27 -0000      1.6
+++ input/regression/arpeggio-bracket.ly        28 Feb 2004 23:35:55 -0000
@@ -10,7 +10,7 @@
 
 \score{
      \notes\relative c''{
-        \override Staff.Arpeggio  #'print-function = \arpeggioBracket
+        \arpeggioBracket
         
         <fis,  d a >\arpeggio
         }
_______________________________________________
Lilypond-devel mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to