On Wed, 20 Jul 2005 01:45:47 +0200
Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote:

> Ishizaki, can you follow our coding style guide lines wrt formatting? 
Ah, sorry for this.  I have not had my Emacs to be set.

> I'm missing documentation changes and ChangeLog entries for your
> patch. 
Should this be included same patch file?
I thought so once, but was not sure.

> Also, the // and /**/ comments are superfluous, so they should be left
> out.
Will do.

> Also, for uniformity with  midi and paper, add your code to 
> lily-parser.cc , and use $defaultheader iso. $globalheader as 
> identifier? Thanks!

Do you mean that a new function (say) "get_header" should be added, 
and header should be handled as one of output_def ?
Then ,its hard for me as not being expert.

Or, just simply write many codes in lily-parser.cc instead of writing
directly in parser.yy ?

Cordially,

------------------------------------------------------------------------
|                         Yoshinobu Ishizaki                           |
|                http://www2c.biglobe.ne.jp/~isizaki/                  |
------------------------------------------------------------------------


_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to