2008/3/4, Reinhold Kainhofer <[EMAIL PROTECTED]>: > > > > Okay, I now took a look at the code and in Tuplet_number::print, there is a > > hardcoded check that kills the tuplet number if the tuplet "does not take > > up any time". In my eyes, this is wrong, since then there is no visual > > indication of a tuplet and the timing appears totally wrong (e.g. three > > dotted quarter notes in a e/4 measure!). > > > > Attached is a patch, which fixes this problem by removing the check for > > zero-length in the tuplet number (but of course the tuplet bracket should > > not be shown for single-note tuplets). > > > Since I didn't get any response whether I could commit or not, here it is > again (with one small fix: Instead of killing the bracket for single-note > tuplets -- which also kills the number -- is simply need to hide the > bracket).
Unfortunately, the commit that added this commit 68d8dd14a88434cd6cf88770713d6e8dca595062 Author: hanwen <hanwen> Date: Mon Mar 20 11:47:12 2006 +0000 does not explain why this change was added, so I guess it's ok. What does make check say of this change? > So, once again: Can I commit this to git or not? Can you add [PATCH] to the subject line when you want a review? I will prioritize when I see that. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
