2008/7/10 Graham Percival <[EMAIL PROTECTED]>:
> There's one typo: "acceidentals". Other than that, looks good to
> me -- Han-Wen, may I commit?
A few suggestions if I may:
- the file should be called arabic-init.ly, like makam-init.ly.
- the example at the top of the file should be changed to use Italian
note names (and shouldn't set \dwn on a sharp note)
- it shouldn't mention version 2.10 since it adds a new feature to the
latest release
- for the custom accidental, there's a nicer slash (with rounded
edges) available in the form of the acciaccatura slash. Here's a new
version of \dwn which also gets rid of the 'text override using
grob-interpret-markup:
dwn = {
\once \override Voice.Accidental #'stencil = #(lambda (grob)
(ly:stencil-combine-at-edge
(ly:accidental-interface::print grob) Y UP
(grob-interpret-markup grob (markup #:line
(#:fontsize -1 (#:musicglyph "flags.ugrace")))) -1.3 0))
}
Regards,
Neil
_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel
