http://codereview.appspot.com/6453/diff/205/6
File lily/arpeggio.cc (right):

http://codereview.appspot.com/6453/diff/205/6#newcode109
Line 109: while (mol.extent (Y_AXIS).length () + EPS < heads.length ())
On 2008/10/03 21:52:28, hanwenn wrote:
why should this be 1e-3? Can you look at some real scans do determine
what a
reasonable number?

It's appreciably larger than the rounding error, which is in the region
of 1e-16 for a global-staff-size of 20, but small enough that it doesn't
interfere with smaller staff sizes.

Also, I'd probably write

  while (mol.extent + squiggle_length < heads.length() + overshoot)


I've tested this, but it breaks cross-staff and cross-voice arpeggios,
which tend to miss the desired notehead by a squiggle.

http://codereview.appspot.com/6453


_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to