Thanks, Neil! All changes made, and pushed after verifying it worked OK.
Regards, Carl On 5/13/09 3:36 PM, "[email protected]" <[email protected]> wrote: > > > http://codereview.appspot.com/62076/diff/2001/1016 > File lily/chord-name-engraver.cc (right): > > http://codereview.appspot.com/62076/diff/2001/1016#newcode20 > Line 20: #include "text-interface.hh" > Goes above #include "warn.hh" > > http://codereview.appspot.com/62076/diff/2001/1016#newcode63 > Line 63: SCM chord_changes = get_property("chordChanges"); > Move this back to its former position? > > http://codereview.appspot.com/62076/diff/2001/1016#newcode75 > Line 75: markup = scm_from_locale_string(""); > Better to return if no markup found. > > http://codereview.appspot.com/62076/diff/2001/1016#newcode149 > Line 149: ASSIGN_EVENT_ONCE(rest_event_ , ev); > ASSIGN_EVENT_ONCE (rest_event_, ev); > > http://codereview.appspot.com/62076/diff/2001/1016#newcode150 > Line 150: > remove blank line > > http://codereview.appspot.com/62076 > > > _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
