Reviewers: Patrick McCarty, Message: Thanks for the review, Patrick.
On 2009/07/16 03:40:58, Patrick McCarty wrote:
http://codereview.appspot.com/8874/diff/2201/3202 File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 Line 2625: (find-brace (binary-search 0 575 get-y-from-brace
scaled-size))
Would Open_type_font::count () return the value 575 you need here?
If it does return 575, I would recommend writing and using a callback
to
retrieve this value, named something like "ly:otf-glyph-count".
An excellent suggestion; I wasn't too happy with the hard-coded value, so this will be a nice refinement. Brace yourself for a new patch set. :) Description: New markup commands: \left-brace & \right-brace. Please review this at http://codereview.appspot.com/8874 Affected files: A input/regression/markup-braces.ly M scm/define-markup-commands.scm M scm/lily-library.scm _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
