-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am Sonntag, 30. August 2009 12:05:18 schrieb [email protected]: > I think $currentbook and $currentbookpart (which might be hyphenized) > ought to be initialized to #f in ly/init.ly, as $defaultheader is, and > set to #f and the end of \book* blocks. It simplifies the test in > add-score.
> http://codereview.appspot.com/112044/diff/1/2#newcode6 > Line 6: ((not (null? (ly:parser-lookup parser '$currentbookpart))) > It's kind of awkward to test if the variable is a book with null? > If $currentbook* are initialized to #f, and set to #f at the end of a > \book* block, the test becomes: > (cond ((ly:parser-lookup parser '$currentbookpart) ... > cond and the first test ought to be on the same line. Okay, it was just that without initialization, the parser-lookup returned '(), so I thought I would use that. - -) Changed '() to #f. - -) Changed $currentbook to $current-book, etc. - -) Added add-score scheme function to lily-library.scm New patch uploaded: http://codereview.appspot.com/112044 Okay to apply? Cheers, Reinhold - -- - ------------------------------------------------------------------ Reinhold Kainhofer, [email protected], http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iD8DBQFKmnWMTqjEwhXvPN0RAuYSAJ4wNXLhHpfv4qwo4IvvfwKh8waXhACfXQYL ijI6Ebaqb7y7K8rdktOX4Xw= =d6mB -----END PGP SIGNATURE----- _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
